Bug 33535 - Wrong ini files fetched when upgrading to 3.2 on DC Master/Backup
Wrong ini files fetched when upgrading to 3.2 on DC Master/Backup
Status: CLOSED FIXED
Product: UCS
Classification: Unclassified
Component: UMC - App-Center
UCS 3.2
Other Linux
: P5 normal (vote)
: UCS 3.2-0-errata
Assigned To: Dirk Wiesenthal
Florian Best
:
Depends on: 33548
Blocks: 33549
  Show dependency treegraph
 
Reported: 2013-11-22 13:09 CET by Dirk Wiesenthal
Modified: 2013-12-12 11:30 CET (History)
2 users (show)

See Also:
What kind of report is it?: ---
What type of bug is this?: ---
Who will be affected by this bug?: ---
How will those affected feel about the bug?: ---
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional):
Max CVSS v3 score:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Dirk Wiesenthal univentionstaff 2013-11-22 13:09:27 CET
The App Center module ships a join script that registers all installed applications. This is done to add the apps to LDAP and to set overview links.

Unfortunately during upgrade this script is called while ucr says version/version is 3.1, so the wrong ini files are fetched and used.

This leads to inconsistencies when the 3.2 ini file changed. Seen in Zarafa: UCSOverviewCategory=False is not evaluated because it is not present in 3.1's ini file.

Probably a problem in DRBD, too. Version changed from 3.1 to 3.2, so the wrong LDAP object is created.

Maybe more apps are affected by this bug.
Comment 1 Dirk Wiesenthal univentionstaff 2013-11-22 13:13:23 CET
Hacky: Overwrite Application.get_metainf_url() to use 3.2. One has to adjust this each time UCS releases a minor or major upgrade...
Comment 2 Dirk Wiesenthal univentionstaff 2013-11-22 14:33:49 CET
Probably better would be a variable version/target/version (or something like that) that could be used and is set at the beginning of univention-upgrade starts (and unset afterwards).

That would not help here, though. The problem is the 3.1 updater
Comment 3 Stefan Gohmann univentionstaff 2013-11-22 20:20:30 CET
I've added UCSOverviewCategory=False to the 3.1 zarafa ini file.
Comment 4 Dirk Wiesenthal univentionstaff 2013-11-22 20:41:06 CET
(In reply to Dirk Wiesenthal from comment #1)
> Good idea: Overwrite Application.get_metainf_url() to use 3.2

Application.get_metainf_url = classmethod(lambda cls: '%s/meta-inf/%s' % (cls.get_server(with_scheme=True), '3.2'))

Then change again for next minor/major release (because Bug#33548 will be fixed)
Comment 5 Dirk Wiesenthal univentionstaff 2013-11-22 22:14:54 CET
Fixed in
  univention-management-console-module-appcenter 3.0.50-5.218.201311222209

YAML updated.

Changelog not created, no version built for next UCS version
Comment 6 Dirk Wiesenthal univentionstaff 2013-11-28 05:46:29 CET
There was another problem: During update, the dpkg status of the packages used as system components were not INSTALLED (have not checked which state it was, probably something like UNPACKED).

Because of strict checks in PackageManager system components did not count as installed. This was fixed, too (on App Center level, not PackageManager level as the check itself is correct in general).

I had to build the package several times to realistically test the update process, thus the high -x version.

Fixed in
  univention-management-console-module-appcenter 3.0.50-13.226.201311280353

QA:

Interesting apps: DRBD (version changed), Zarafa (no overview links shall be created), OX (both), Samba 4 (system component that may receive an update along with this errata update)

Check other apps, too.

The problem is that UCSOverviewCategory=False was added to 3.1's Zarafa and OX shortly after this bug was found. This is not reproducible anymore without getting creative.
Comment 7 Florian Best univentionstaff 2013-12-11 11:17:01 CET
Ok, after installing the errata update the system components are correctly registered, also the DRBD version is correct.

Code-Review: OK
YAML: OK
Comment 8 Moritz Muehlenhoff univentionstaff 2013-12-12 11:30:40 CET
http://errata.univention.de/ucs/3.2/8.html