Bug 36633

Summary:	python undefined name in s4-connector
Product:	UCS	Reporter:	Florian Best <best>
Component:	S4 Connector	Assignee:	Florian Best <best>
Status:	CLOSED FIXED	QA Contact:	Arvid Requate <requate>
Severity:	normal
Priority:	P5	CC:	gohmann, requate
Version:	UCS 4.2
Target Milestone:	UCS 4.4-1-errata
Hardware:	Other
OS:	Linux
What kind of report is it?:	Development Internal	What type of bug is this?:	---
Who will be affected by this bug?:	---	How will those affected feel about the bug?:	---
User Pain:		Enterprise Customer affected?:
School Customer affected?:		ISV affected?:
Waiting Support:		Flags outvoted (downgraded) after PO Review:
Ticket number:		Bug group (optional):	Cleanup
Max CVSS v3 score:
Attachments:	Patch 1.patch

Description Florian Best

2014-11-13 12:49:09 CET

./services/univention-s4-connector/s4-connector.py:100: undefined name 'ud'
./services/univention-s4-connector/s4-connector.py:100: undefined name 'ud'
./services/univention-s4-connector/s4-connector.py:100: undefined name 'ud'
./services/univention-s4-connector/s4-connector.py:110: undefined name 'ud'
./services/univention-s4-connector/s4-connector.py:110: undefined name 'ud'
./services/univention-s4-connector/s4-connector.py:110: undefined name 'ud'

Comment 1 Florian Best

2016-09-12 16:09:56 CEST

./services/univention-s4-connector/sync_krbtgt:142:79: F821 undefined name 'username'
./services/univention-s4-connector/sync_krbtgt:143:56: F821 undefined name 'username'

Comment 2 jp 2018-06-13 15:43:03 CEST

Created attachment 9554 [details]
Patch

ud was already fixed, there is no "ud" anymore.

Comment 3 Florian Best

2019-08-08 13:08:20 CEST

Removed the undefined variables from code.

univention-s4-connector (13.0.2-28)
cb68a31a33f5 | Bug #36633: fix some reference errors

univention-s4-connector.yaml
cb68a31a33f5 | Bug #36633: fix some reference errors

Comment 4 Arvid Requate

2019-08-08 23:02:28 CEST

Created attachment 10154 [details]
1.patch

I think this change doesn't make too much sense:

-                       ntPwd = binascii.b2a_hex(unicodePwd_attr).upper()
+                       binascii.b2a_hex(unicodePwd_attr).upper()  # nt hash

See attached patch, I'd just remove the lines?

Comment 5 Florian Best

2019-08-08 23:18:52 CEST

OK: patch applied

univention-s4-connector (13.0.2-35)
a61641e40643 | Bug #36633: remove more unused code

Comment 6 Arvid Requate

2019-08-09 09:58:40 CEST

773ac2116d | Advisory version number update

Verified:
* Code review
* Functional test for sync_krbtgt
* Advisory

Comment 7 Arvid Requate

2019-08-22 15:29:54 CEST

<http://errata.software-univention.de/ucs/4.4/239.html>