Bug 36633 – python undefined name in s4-connector

Bug 36633 - python undefined name in s4-connector


Summary:	python undefined name in s4-connector

Status:	CLOSED FIXED

Product:	UCS
Classification:	Unclassified
Component:	S4 Connector
Version:	UCS 4.2
Hardware:	Other Linux

Importance:	P5 normal (vote)
Target Milestone:	UCS 4.4-1-errata
Assigned To:	Florian Best
QA Contact:	Arvid Requate

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2014-11-13 12:49 CET by Florian Best
Modified:	2019-08-22 15:29 CEST (History)
CC List:	2 users (show)

See Also:
What kind of report is it?:	Development Internal
What type of bug is this?:	---
Who will be affected by this bug?:	---
How will those affected feel about the bug?:	---
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional):	Cleanup
Max CVSS v3 score:

Attachments
Patch (799 bytes, text/plain) 2018-06-13 15:43 CEST, jp	Details
1.patch (721 bytes, patch) 2019-08-08 23:02 CEST, Arvid Requate	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Florian Best

2014-11-13 12:49:09 CET

./services/univention-s4-connector/s4-connector.py:100: undefined name 'ud'
./services/univention-s4-connector/s4-connector.py:100: undefined name 'ud'
./services/univention-s4-connector/s4-connector.py:100: undefined name 'ud'
./services/univention-s4-connector/s4-connector.py:110: undefined name 'ud'
./services/univention-s4-connector/s4-connector.py:110: undefined name 'ud'
./services/univention-s4-connector/s4-connector.py:110: undefined name 'ud'

Comment 1 Florian Best

2016-09-12 16:09:56 CEST

./services/univention-s4-connector/sync_krbtgt:142:79: F821 undefined name 'username'
./services/univention-s4-connector/sync_krbtgt:143:56: F821 undefined name 'username'

Comment 2 jp 2018-06-13 15:43:03 CEST

Created attachment 9554 [details]
Patch

ud was already fixed, there is no "ud" anymore.

Comment 3 Florian Best

2019-08-08 13:08:20 CEST

Removed the undefined variables from code.

univention-s4-connector (13.0.2-28)
cb68a31a33f5 | Bug #36633: fix some reference errors

univention-s4-connector.yaml
cb68a31a33f5 | Bug #36633: fix some reference errors

Comment 4 Arvid Requate

2019-08-08 23:02:28 CEST

Created attachment 10154 [details]
1.patch

I think this change doesn't make too much sense:

-                       ntPwd = binascii.b2a_hex(unicodePwd_attr).upper()
+                       binascii.b2a_hex(unicodePwd_attr).upper()  # nt hash

See attached patch, I'd just remove the lines?

Comment 5 Florian Best

2019-08-08 23:18:52 CEST

OK: patch applied

univention-s4-connector (13.0.2-35)
a61641e40643 | Bug #36633: remove more unused code

Comment 6 Arvid Requate

2019-08-09 09:58:40 CEST

773ac2116d | Advisory version number update

Verified:
* Code review
* Functional test for sync_krbtgt
* Advisory

Comment 7 Arvid Requate

2019-08-22 15:29:54 CEST

<http://errata.software-univention.de/ucs/4.4/239.html>