Bug 39079

Summary:	Sysprep joins fail on Samba >= 4.2.0
Product:	UCS	Reporter:	Janis Meybohm <meybohm>
Component:	Samba4	Assignee:	Felix Botner <botner>
Status:	CLOSED FIXED	QA Contact:	Stefan Gohmann <gohmann>
Severity:	normal
Priority:	P5	CC:	gohmann, markus.daehlmann, requate, walkenhorst
Version:	UCS 4.0
Target Milestone:	UCS 4.0-3-errata
Hardware:	Other
OS:	Linux
What kind of report is it?:	---	What type of bug is this?:	---
Who will be affected by this bug?:	---	How will those affected feel about the bug?:	---
User Pain:		Enterprise Customer affected?:
School Customer affected?:		ISV affected?:
Waiting Support:		Flags outvoted (downgraded) after PO Review:
Ticket number:		Bug group (optional):
Max CVSS v3 score:
Attachments:	reproduce.c

Description Janis Meybohm

2015-08-04 16:26:03 CEST

Several customers complained about trouble with unattended join of Windows clients:
Ticket#2015021921000117
Ticket#2015040121000263
Ticket#2015080321000501

The last customer had some old logs at hand so a diff of working/not working log was finally possible and he pointed out to the line:

-- NOT working
NetpJoinDomainOnDs: Passed DC 'dc.customer.de' NOT verified as DNS name 'dc.customer.de'

-- vs. working:
NetpJoinDomainOnDs: Passed DC 'dc.customer.de' verified as DNS name '\\dc.customer.de'


There is a similar report on samba-technical identifying the probably breaking commit as 927a1030d78c25dbc43b6470f9ffe8b5fe664835

<https://lists.samba.org/archive/samba-technical/2015-August/108878.html>

Comment 1 Janis Meybohm

2015-08-11 09:50:21 CEST

Customer reported that unattend join is possible again with 927a1030d78c25dbc43b6470f9ffe8b5fe664835 removed.

Comment 2 Arvid Requate

2015-08-14 11:31:18 CEST

That should be fixed in v4-3-stable by

 https://git.samba.org/?p=samba.git;a=commit;h=459d1d3fb9a5282d19121eaacba9d611896b37ff

which is not yet in v4-2-stable. It should work again in samba >= 4.3.0rc1.


-                       dc_name[0] == '\\'? "\\\\":"",
+                       dc_name[0] != '\\'? "\\\\":"",

Comment 3 Arvid Requate

2015-08-14 11:38:00 CEST

Created attachment 7109 [details]
reproduce.c

For the record: Before I found the missing commit I identified the problem by writing this incredibly sophisticated code. Always a pleasure.

Comment 4 Felix Botner

2015-08-27 10:45:39 CEST

Added 

4.0-0-0-ucs/2:4.2.3-1-errata4.0-3/99_bug39079.patch
-                      dc_name[0] == '\\'? "\\\\":"",
+                      dc_name[0] != '\\'? "\\\\":"",


YAML: 2015-08-12-samba.yaml

Comment 5 Stefan Gohmann

2015-08-27 15:07:00 CEST

Code review: OK

Build log: OK

ucs-test: OK

YAML: OK

Comment 6 Janek Walkenhorst

2015-08-27 18:14:22 CEST

<http://errata.univention.de/ucs/4.0/289.html>