Bug 39079 – Sysprep joins fail on Samba >= 4.2.0

Bug 39079 - Sysprep joins fail on Samba >= 4.2.0


Summary:	Sysprep joins fail on Samba >= 4.2.0

Status:	CLOSED FIXED

Product:	UCS
Classification:	Unclassified
Component:	Samba4
Version:	UCS 4.0
Hardware:	Other Linux

Importance:	P5 normal (vote)
Target Milestone:	UCS 4.0-3-errata
Assigned To:	Felix Botner
QA Contact:	Stefan Gohmann

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2015-08-04 16:26 CEST by Janis Meybohm
Modified:	2015-08-27 18:14 CEST (History)
CC List:	4 users (show)

See Also:
What kind of report is it?:	---
What type of bug is this?:	---
Who will be affected by this bug?:	---
How will those affected feel about the bug?:	---
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional):
Max CVSS v3 score:

Attachments
reproduce.c (1.02 KB, text/plain) 2015-08-14 11:38 CEST, Arvid Requate	Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Janis Meybohm

2015-08-04 16:26:03 CEST

Several customers complained about trouble with unattended join of Windows clients:
Ticket#2015021921000117
Ticket#2015040121000263
Ticket#2015080321000501

The last customer had some old logs at hand so a diff of working/not working log was finally possible and he pointed out to the line:

-- NOT working
NetpJoinDomainOnDs: Passed DC 'dc.customer.de' NOT verified as DNS name 'dc.customer.de'

-- vs. working:
NetpJoinDomainOnDs: Passed DC 'dc.customer.de' verified as DNS name '\\dc.customer.de'


There is a similar report on samba-technical identifying the probably breaking commit as 927a1030d78c25dbc43b6470f9ffe8b5fe664835

<https://lists.samba.org/archive/samba-technical/2015-August/108878.html>

Comment 1 Janis Meybohm

2015-08-11 09:50:21 CEST

Customer reported that unattend join is possible again with 927a1030d78c25dbc43b6470f9ffe8b5fe664835 removed.

Comment 2 Arvid Requate

2015-08-14 11:31:18 CEST

That should be fixed in v4-3-stable by

 https://git.samba.org/?p=samba.git;a=commit;h=459d1d3fb9a5282d19121eaacba9d611896b37ff

which is not yet in v4-2-stable. It should work again in samba >= 4.3.0rc1.


-                       dc_name[0] == '\\'? "\\\\":"",
+                       dc_name[0] != '\\'? "\\\\":"",

Comment 3 Arvid Requate

2015-08-14 11:38:00 CEST

Created attachment 7109 [details]
reproduce.c

For the record: Before I found the missing commit I identified the problem by writing this incredibly sophisticated code. Always a pleasure.

Comment 4 Felix Botner

2015-08-27 10:45:39 CEST

Added 

4.0-0-0-ucs/2:4.2.3-1-errata4.0-3/99_bug39079.patch
-                      dc_name[0] == '\\'? "\\\\":"",
+                      dc_name[0] != '\\'? "\\\\":"",


YAML: 2015-08-12-samba.yaml

Comment 5 Stefan Gohmann

2015-08-27 15:07:00 CEST

Code review: OK

Build log: OK

ucs-test: OK

YAML: OK

Comment 6 Janek Walkenhorst

2015-08-27 18:14:22 CEST

<http://errata.univention.de/ucs/4.0/289.html>