Bug 40348

Summary: syntax check for Base64GzipText always invalid
Product: UCS Reporter: Daniel Tröder <troeder>
Component: UDM (Generic)Assignee: Daniel Tröder <troeder>
Status: CLOSED FIXED QA Contact: Florian Best <best>
Severity: normal    
Priority: P5 CC: gohmann, walkenhorst
Version: UCS 4.1   
Target Milestone: UCS 4.1-0-errata   
Hardware: Other   
OS: Linux   
What kind of report is it?: --- What type of bug is this?: ---
Who will be affected by this bug?: --- How will those affected feel about the bug?: ---
User Pain: Enterprise Customer affected?:
School Customer affected?: ISV affected?:
Waiting Support: Flags outvoted (downgraded) after PO Review:
Ticket number: Bug group (optional):
Max CVSS v3 score:
Bug Depends on:    
Bug Blocks: 38950    

Description Daniel Tröder univentionstaff 2015-12-29 14:21:20 CET
syntax.py checks for Base64GzipText with:

zlib.decompress(gziped_data, 16+zlib.MAX_WBITS)

Which is invalid as the 2nd argument wbits may only be <= zlib.MAX_WBITS. This results always in
---
error: Error -3 while decompressing data: incorrect header check
---

Removing the wbits argument fixes the issue. Its default value is zlib.MAX_WBITS anyway (https://docs.python.org/2/library/zlib.html#zlib.decompress).
Comment 1 Daniel Tröder univentionstaff 2016-01-04 09:31:45 CET
The syntax check was fixed in commits 66549 and 66550.
Comment 2 Florian Best univentionstaff 2016-01-11 14:05:31 CET
Fix: OK
YAML: OK
Comment 3 Janek Walkenhorst univentionstaff 2016-01-27 16:28:12 CET
<http://errata.software-univention.de/ucs/4.1/68.html>