Bug 40348 – syntax check for Base64GzipText always invalid

Bug 40348 - syntax check for Base64GzipText always invalid


Summary:	syntax check for Base64GzipText always invalid

Status:	CLOSED FIXED

Product:	UCS
Classification:	Unclassified
Component:	UDM (Generic)
Version:	UCS 4.1
Hardware:	Other Linux

Importance:	P5 normal (vote)
Target Milestone:	UCS 4.1-0-errata
Assigned To:	Daniel Tröder
QA Contact:	Florian Best

URL:
Keywords:

Depends on:
Blocks:	38950
	Show dependency tree / graph

Reported:	2015-12-29 14:21 CET by Daniel Tröder
Modified:	2016-03-18 10:04 CET (History)
CC List:	2 users (show)

See Also:
What kind of report is it?:	---
What type of bug is this?:	---
Who will be affected by this bug?:	---
How will those affected feel about the bug?:	---
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional):
Max CVSS v3 score:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Daniel Tröder

2015-12-29 14:21:20 CET

syntax.py checks for Base64GzipText with:

zlib.decompress(gziped_data, 16+zlib.MAX_WBITS)

Which is invalid as the 2nd argument wbits may only be <= zlib.MAX_WBITS. This results always in
---
error: Error -3 while decompressing data: incorrect header check
---

Removing the wbits argument fixes the issue. Its default value is zlib.MAX_WBITS anyway (https://docs.python.org/2/library/zlib.html#zlib.decompress).

Comment 1 Daniel Tröder

2016-01-04 09:31:45 CET

The syntax check was fixed in commits 66549 and 66550.

Comment 2 Florian Best

2016-01-11 14:05:31 CET

Fix: OK
YAML: OK

Comment 3 Janek Walkenhorst

2016-01-27 16:28:12 CET

<http://errata.software-univention.de/ucs/4.1/68.html>