Univention Bugzilla – Full Text Bug Listing |
Summary: | App Center Self Service: Dev-Tools | ||
---|---|---|---|
Product: | UCS | Reporter: | Dirk Wiesenthal <wiesenthal> |
Component: | App Center | Assignee: | Dirk Wiesenthal <wiesenthal> |
Status: | CLOSED FIXED | QA Contact: | Felix Botner <botner> |
Severity: | normal | ||
Priority: | P1 | CC: | gohmann, gulden |
Version: | UCS 4.1 | ||
Target Milestone: | UCS 4.1-3-errata | ||
Hardware: | Other | ||
OS: | Linux | ||
See Also: | https://forge.univention.org/bugzilla/show_bug.cgi?id=42060 | ||
What kind of report is it?: | Development Internal | What type of bug is this?: | --- |
Who will be affected by this bug?: | --- | How will those affected feel about the bug?: | --- |
User Pain: | Enterprise Customer affected?: | ||
School Customer affected?: | ISV affected?: | ||
Waiting Support: | Flags outvoted (downgraded) after PO Review: | ||
Ticket number: | Bug group (optional): | ||
Max CVSS v3 score: | |||
Bug Depends on: | 41869 | ||
Bug Blocks: |
Description
Dirk Wiesenthal
2016-07-25 22:52:08 CEST
univention-app dev-list univention-app dev-status APPID univention-app dev-download 4.1 COMPONENTID --include-packages univention-app dev-new-version 4.1 APPID --new-app-version=2.0 univention-app dev-upload --clear 4.1 COMPONENTID appid.ini screenshot=myscreenshot.png README_EN *.deb univention-app dev-publish 4.1 COMPONENTID univention-app dev-new-version-upload-publish (three actions combined in one) univention-appcenter 5.0.21-30.202.201607252257 OK - univention-app dev-* OK - yaml But im not sure if univention-appcenter is the right place for the selfservice dev tools. I would prefer to put these tools in a different source package as the univention-appcenter package becomes too overloaded (univention-appcenter errata for every change in the selfservice dev tools?). For now OK. As discussed, please revert the changes as they break the updater test With this patch actions/__init__.py raises instead of returing 10 in the case of an error. This breaks univention-upgrade.app_upgrade_search.call (if for example the appcenter is not reachable, which is the case in many update tests). http://jenkins.knut.univention.de:8080/job/UCS-4.1/job/UCS-4.1-2/job/AutotestJoin/99/SambaVersion=s3,Systemrolle=member/#showFailuresLink We need a change in univention-upgrade (ingnore app_upgrade_search.call() exceptions) for this patch. Reverted in univention-appcenter 5.0.21-32.204.201607281722 For reference: r71230 can be used to again fix this bug. Cannot be applied as is because of local_appcenter.py which has seen a patch due to Bug#39551 If I see it correctly, no changes are in SVN and we can move it to 4.1-3-errata. Unreverted Why do we need self services management tools in our univention-appcenter package? I think this is a bad idea. * every change on the services management tools results in a errata for univention-appcenter * one has to install UCS to use the self services management tools * as we need a set of bash scripts for this anyway (to enable ISV's to manage the self service via cmdline without the need to setup UCS) i don't see the point of this Please speak to stefan if we really want to do this, otherwise revert the changes. I would prefer something like this. -> curl -Ssf https://selfservice.software-univention.de/selfservice.sh | bash -s -- dev-new-version --username ... You are right, there needs to be a Non-UCS-script at some point in time. I thought it would be good if first, the functionality is checked. In a second step I would create a separate script. Anyway, now the script is here: https://selfservice.software-univention.de/appcenter-selfservice/univention-appcenter-selfservice It is Python (because I really do not want to do argument parsing, response parsing, error messages in bash). And it is somehow based on univention-app. This does all the argparse / subparser stuff for me plus some subprocessing and logging. Also, I tested all of it with univention-app. As it had to be UCS independent, I copied _a lot_ of code from univention-appcenter, making the script ~600 lines long. For univention-appcenter, there is still some QA work. I changed call() to not return 10 when Abort() is raised. If one needs this "feature", or does not want to change too much in existing code, call_safe() has been added. please just fix the univention-appcenter's yaml file here, i opened a new bug #42060 for the self service tool. FAIL - YAML (Added a couple of extensions to "univ..., Version) OK - reverted OK - upgrade uses call_safe (updater test OK) Removed from YAML OK |