Univention Bugzilla – Bug 41869
univention-upgrade: Do not fail if App Center is not reachable
Last modified: 2016-10-04 14:03:32 CEST
This breaks univention-upgrade.app_upgrade_search.call (if for example the appcenter is not reachable, which is the case in many update tests). +++ This bug was initially created as a clone of Bug #41853 +++ We need dev Tools for working with the Test App Center / Self Service via command line. First step: univention-app extensions.
Using call_safe() instead of call() in univention-updater 11.0.11-3.1483.201608160000
OK: r71728 OK: ip route add prohibit "$(dig +short appcenter.software-univention.de)" univention-upgrade --check Checking for app updates: An error occurred - see "/var/log/univention/updater.log" for details
FAIL: r72203 is not merged into UCS-4.2 FYI: bad karma points for "UserCancelled": using exception for flow control is an anti-pattern!
(In reply to Philipp Hahn from comment #3) > FAIL: r72203 is not merged into UCS-4.2 > This is actually Bug#41840 The whole change is essentially: - app_upgrade_search.call() + try: + app_upgrade_search.call() + except Abort: + pass (maybe I changed something in the import section, but this, too, is the same in 4.1-3 as in 4.2-0) > FYI: bad karma points for "UserCancelled": using exception for flow control > is an anti-pattern! Fortunately, this will be reverted.
(In reply to Dirk Wiesenthal from comment #4) > > FYI: bad karma points for "UserCancelled": using exception for flow control > > is an anti-pattern! > > Fortunately, this will be reverted. The "Abort"-exception is the same btw ^^
OK: 11.0.11-8.1490.201609201429 OK: 4.1-3 OK: 4.2-0 OK: errata-announce -V --only univention-updater.yaml FIXED: univention-updater.yaml r72716
<http://errata.software-univention.de/ucs/4.1/275.html>