Bug 43506

Summary: Software selection is broken
Product: UCS Reporter: Stefan Gohmann <gohmann>
Component: UMC - Setup wizardAssignee: Eduard Mai <mai>
Status: CLOSED FIXED QA Contact: Erik Damrose <damrose>
Severity: normal    
Priority: P5 CC: best, damrose, klaeser, mai
Version: UCS 4.1Keywords: interim-2
Target Milestone: UCS 4.2   
Hardware: Other   
OS: Linux   
See Also: https://forge.univention.org/bugzilla/show_bug.cgi?id=40102
https://forge.univention.org/bugzilla/show_bug.cgi?id=43451
https://forge.univention.org/bugzilla/show_bug.cgi?id=43864
What kind of report is it?: Development Internal What type of bug is this?: ---
Who will be affected by this bug?: --- How will those affected feel about the bug?: ---
User Pain: Enterprise Customer affected?:
School Customer affected?: ISV affected?:
Waiting Support: Flags outvoted (downgraded) after PO Review:
Ticket number: Bug group (optional):
Max CVSS v3 score:
Attachments: ucs42-installer.png

Description Stefan Gohmann univentionstaff 2017-02-07 06:19:28 CET
Created attachment 8407 [details]
ucs42-installer.png

The installer software selection looks broken, see attached screenshot.
Comment 1 Stefan Gohmann univentionstaff 2017-02-07 06:21:51 CET
I've disabled the software selection for the first milestone of UCS 4.2. Please re-enable it after fixing this issue: r76480
Comment 2 Florian Best univentionstaff 2017-02-07 10:02:19 CET
This is either Bug #43451 or Bug #40102.
Comment 3 Florian Best univentionstaff 2017-02-08 18:06:54 CET
Should be fixed?!
Comment 4 Eduard Mai univentionstaff 2017-02-10 18:33:20 CET
After a first investigation this appears to be triggered(In reply to Florian Best from comment #3)
> Should be fixed?!

After a first investigation there seems to be a new issue here. Initially the query to setup/apps/query was empty because of a bug in univention-appcenters app.is_ucs_component(). No there seems to be a problem with the cache:

Traceback (most recent call last):
  File "/usr/lib/pymodules/python2.7/univention/management/console/base.py", line 312, in execute
    function.__func__(self, request, *args, **kwargs)
  File "/usr/lib/pymodules/python2.7/univention/management/console/modules/decorators.py", line 318, in _response
    result = _multi_response(self, request)
  File "/usr/lib/pymodules/python2.7/univention/management/console/modules/decorators.py", line 454, in _response
    return list(function(self, iterator, *nones))
  File "/usr/lib/pymodules/python2.7/univention/management/console/modules/decorators.py", line 284, in _fake_func
    yield function(self, *args)
  File "/usr/lib/pymodules/python2.7/univention/management/console/modules/setup/__init__.py", line 730, in apps_query
    return util.get_apps(True)
  File "/usr/lib/pymodules/python2.7/univention/management/console/modules/setup/util.py", line 770, in get_apps
    return [Get.to_dict(app) for app in AppManager.get_all_apps() if app.is_ucs_component()]
  File "/usr/lib/pymodules/python2.7/univention/appcenter/app.py", line 1089, in is_ucs_component
    return 'UCS components' in app.categories
AttributeError: 'NoneType' object has no attribute 'categories'
Comment 5 Alexander Kläser univentionstaff 2017-02-28 13:13:55 CET
I fixed some a few JavaScript errors and styling issues for the software selection grid. Changelog entry is not necessary.

univention-system-setup (10.0.7-13):
r77145 | Bug #43506: Adjust query for correct software components
r77143 | Bug #43506: Fix errors and styling for software selection
Comment 6 Alexander Kläser univentionstaff 2017-02-28 13:16:02 CET
BTW, there was a logic error as _getRole() would return undefined for the fast demo mode. The method now returns "domaincontroller_master" for the demo mode.
Comment 7 Erik Damrose univentionstaff 2017-02-28 14:53:47 CET
reopen: there is still no entry in the software selection grid. The apps/query request returns nothing.
Comment 8 Eduard Mai univentionstaff 2017-02-28 18:27:19 CET
UCS 4.2:

Revision 77174 and 77175 replace deprecated parts of the appcenter API.

Package: univention-system-setup
Version: 10.0.7-14A~4.2.0.201702281804
Branch: ucs_4.2-0
Comment 9 Erik Damrose univentionstaff 2017-03-01 11:09:39 CET
Great, i can now select software in the grid. Verified. Interim bug, no changelog required.
Comment 10 Stefan Gohmann univentionstaff 2017-04-04 18:28:14 CEST
UCS 4.2 has been released:
 https://docs.software-univention.de/release-notes-4.2-0-en.html
 https://docs.software-univention.de/release-notes-4.2-0-de.html

If this error occurs again, please use "Clone This Bug".