Bug 40102 - univention-system-setup-boot should not depend on umc-appcenter code
univention-system-setup-boot should not depend on umc-appcenter code
Status: CLOSED FIXED
Product: UCS
Classification: Unclassified
Component: System setup
UCS 4.1
Other Linux
: P5 normal (vote)
: UCS 4.1-4-errata
Assigned To: Eduard Mai
Dirk Wiesenthal
:
: 37046 43307 (view as bug list)
Depends on: 43363
Blocks:
  Show dependency treegraph
 
Reported: 2015-11-25 10:54 CET by Dirk Wiesenthal
Modified: 2017-02-23 11:22 CET (History)
4 users (show)

See Also:
What kind of report is it?: Bug Report
What type of bug is this?: 6: Setup Problem: Issue for the setup process
Who will be affected by this bug?: 1: Will affect a very few installed domains
How will those affected feel about the bug?: 3: A User would likely not purchase the product
User Pain: 0.103
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number: 2017020921000212
Bug group (optional): Cleanup
Max CVSS v3 score:


Attachments
Screenshot (310.84 KB, image/png)
2017-02-02 15:07 CET, Florian Best
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Dirk Wiesenthal univentionstaff 2015-11-25 10:54:54 CET
Instead it should use the App Center lib for the software page.
Comment 1 Dirk Wiesenthal univentionstaff 2016-12-08 14:46:45 CET
Causes a lot of tracebacks:

Version: 4.1-4 errata324 (Vahr)

Traceback(8da6cbe0cda78882b1862e3d97c57c96): 
Execution of command 'setup/apps/query wizard' has failed:

Traceback (most recent call last):
  File "%PY2.7%/univention/management/console/base.py", line 283, in execute
    function(self, request)
  File "%PY2.7%/univention/management/console/modules/decorators.py", line 318, in _response
    result = _multi_response(self, request)
  File "%PY2.7%/univention/management/console/modules/decorators.py", line 462, in _response
    return list(function(self, iterator, *nones))
  File "%PY2.7%/univention/management/console/modules/decorators.py", line 284, in _fake_func
    yield function(self, *args)
  File "%PY2.7%/univention/management/console/modules/setup/__init__.py", line 751, in apps_query
    return util.get_apps(True)
  File "%PY2.7%/univention/management/console/modules/setup/util.py", line 778, in get_apps
    applications = app_center.Application.all(only_local=True)
  File "%PY2.7%/univention/management/console/modules/appcenter/app_center.py", line 838, in all
    cls._all_applications.append(Application(ini_file, localize))
  File "%PY2.7%/univention/management/console/modules/appcenter/app_center.py", line 314, in __init__
    for k, v in config.items('Application'):
  File "/usr/lib/python2.7/ConfigParser.py", line 642, in items
    raise NoSectionError(section)
NoSectionError: No section: 'Application'
Comment 2 Alexander Kläser univentionstaff 2016-12-16 23:48:19 CET
AFAIS, this is a duplicate of 37151, it is the same traceback there.

*** This bug has been marked as a duplicate of bug 37151 ***
Comment 3 Alexander Kläser univentionstaff 2016-12-16 23:48:54 CET
... typo, I meant Bug 37515 !

*** This bug has been marked as a duplicate of bug 37515 ***
Comment 4 Dirk Wiesenthal univentionstaff 2016-12-17 00:27:44 CET
Not really. This is system-setup. The other one is App Center. I would like to not fix it in the App Center. The traceback comes from the old code base.
Comment 5 Florian Best univentionstaff 2016-12-20 10:39:40 CET
Can you explain what you want to change?
The dependency in univention-system-setup-boot should be changed from  univention-management-console-module-appcenter to univention-appcenter?
Comment 6 Dirk Wiesenthal univentionstaff 2016-12-20 10:47:57 CET
python-univention-appcenter, yes. And I want to use the "new" App class, not the old "Application" class from the UMC module.
Comment 7 Florian Best univentionstaff 2016-12-20 10:55:32 CET
Ah okay, thanks. This sounds good.
Comment 8 Florian Best univentionstaff 2017-01-06 10:32:18 CET
*** Bug 43307 has been marked as a duplicate of this bug. ***
Comment 9 Florian Best univentionstaff 2017-01-13 15:28:57 CET
- univention-management-console-module-appcenter,
+ univention-appcenter,
→ this needs to be python-univention-appcenter
Comment 10 Florian Best univentionstaff 2017-01-13 16:22:45 CET
Please always merge your changes to UCS 4.2, as well!
Comment 11 Eduard Mai univentionstaff 2017-01-13 17:27:11 CET
r75751 through r75756 remove the calls to the old API and make slight changes to accommodate the front end.
r75752 fixes a typo in univention-appcenter that needed to be corrected in order to correctly determine UCS components with the new univention-appcenter API.

UCS 4.1-4:
Package: univention-system-setup
Version: 9.0.6-5.1005.201701131706
Branch: ucs_4.1-0
Scope: errata4.1-4

Package: univention-appcenter
Version: 5.0.23-32.259.201701131558
Branch: ucs_4.1-0
Scope: errata4.1-4
Comment 12 Eduard Mai univentionstaff 2017-01-13 17:56:18 CET
UCS 4.2:
r75771 and r75773 merge the changes in system-setup into UCS 4.2.
r75772 merges changes in univention-appcenter.

Package: univention-appcenter
Version: 6.0.0-27A~4.2.0.201701131752
Branch: ucs_4.2-0
Comment 13 Eduard Mai univentionstaff 2017-01-13 18:49:41 CET
UCS 4.1-4:
r75778 and r75779 remove dead code and add an explicit build dependency to python-univention-appcenter

Package: univention-system-setup
Version: 9.0.6-6.1006.201701131842
Branch: ucs_4.1-0
Scope: errata4.1-4

UCS 4.2:
r75775 and r75775 merges those changes into UCS 4.2.

Package: univention-system-setup
Version: 10.0.2-3A~4.2.0.201701131833
Branch: ucs_4.2-0
Comment 14 Eduard Mai univentionstaff 2017-01-17 16:45:13 CET
r75873 fixes the app query.
r75875: yaml

UCS 4.1-4:
Package: univention-system-setup
Version: 9.0.6-7.1007.201701171558
Branch: ucs_4.1-0-errata4.1-4
Comment 15 Eduard Mai univentionstaff 2017-01-17 16:57:19 CET
r75876 merges changes into UCS 4.2.

Package: univention-system-setup
Version: 10.0.2-4A~4.2.0.201701171651
Branch: ucs_4.2-0
Comment 16 Florian Best univentionstaff 2017-01-17 17:01:40 CET
*** Bug 37046 has been marked as a duplicate of this bug. ***
Comment 17 Dirk Wiesenthal univentionstaff 2017-01-18 00:19:10 CET
The grid's info buttons show "undefined", because you are accessing "longdescription" instead of "long_description".

The long_description is not entities.decode()d. You will see "<p>Paragraph content...".

Changing the locale does not load the correctly localized Apps. Please remove
  global _apps
Instead if no_cache: AppManager.clear_cache()

Also, please use get_action('get')
Comment 18 Dirk Wiesenthal univentionstaff 2017-01-18 00:22:49 CET
(In reply to Dirk Wiesenthal from comment #17)
> Also, please use get_action('get')

Hmmmm... in terms of performance, you can use Get class. I guess it is good as is.
Comment 19 Eduard Mai univentionstaff 2017-01-20 17:02:10 CET
UCS 4.1-4:

r75973: HTML elements are now correctly decoded for long_description. AppManger is used to handle the cached instead of global _apps.
 
r75975, r75976, r75977: work around missing build dependencies.

Package: univention-system-setup
Version: 9.0.6-11.1011.201701201654
Branch: ucs_4.1-0
Scope: errata4.1-4
Comment 20 Eduard Mai univentionstaff 2017-01-20 17:35:24 CET
UCS 4.2:

r75978 through r75981: Merge all of comment #19 into UCS 4.2

Package: univention-system-setup
Version: 10.0.2-5A~4.2.0.201701201728
Branch: ucs_4.2-0
Comment 21 Florian Best univentionstaff 2017-02-02 15:07:18 CET
Created attachment 8397 [details]
Screenshot
Comment 22 Florian Best univentionstaff 2017-02-02 15:07:46 CET
(In reply to Florian Best from comment #21)
> Created attachment 8397 [details]
> Screenshot
I suspect this changes to break the software selection on the UCS 4.2 DVD from 2 days ago.
Comment 23 Eduard Mai univentionstaff 2017-02-03 18:13:40 CET
Commits r76354 through 76357 fix remaining usage of old API property names in the changed code path.

UCS 4.2:
Package: univention-system-setup
Version: 10.0.4-3A~4.2.0.201702022221

UCS 4.1-4:
Package: univention-system-setup
Version: 9.0.7-1.1012.201702022201
Comment 24 Eduard Mai univentionstaff 2017-02-03 18:29:04 CET
Apologies, UCS 4.1-4 is:

Version: 9.0.7-2.1013.201702022221
Branch: ucs_4.1-0-errata4.1-4
Scope: errata4.1-4
Comment 25 Dirk Wiesenthal univentionstaff 2017-02-08 09:58:54 CET
OK, works as expected. I have changed the version in the YAML file.
Comment 26 Janek Walkenhorst univentionstaff 2017-02-08 14:22:52 CET
<http://errata.software-univention.de/ucs/4.1/388.html>
Comment 27 Florian Best univentionstaff 2017-02-23 11:22:15 CET
Version: 4.1-4 errata324 (Vahr)

Remark: Template [UCS: 4.1-4 amd64 - generic-unsafe] auf frosta, Sprache von Englisch auf Deutsch umgestellt.