Bug 49024

Summary: getRootDnConnection broken
Product: UCS Reporter: Felix Botner <botner>
Component: LDAPAssignee: Felix Botner <botner>
Status: CLOSED FIXED QA Contact: Florian Best <best>
Severity: normal    
Priority: P5    
Version: UCS 4.4   
Target Milestone: UCS 4.4-0-errata   
Hardware: Other   
OS: Linux   
What kind of report is it?: Development Internal What type of bug is this?: ---
Who will be affected by this bug?: --- How will those affected feel about the bug?: ---
User Pain: Enterprise Customer affected?:
School Customer affected?: ISV affected?:
Waiting Support: Flags outvoted (downgraded) after PO Review:
Ticket number: Bug group (optional):
Max CVSS v3 score:

Description Felix Botner univentionstaff 2019-03-18 09:57:33 CET
getRootDnConnection:

bindpw = open('/etc/ldap/rootpw.conf').read().rstrip('\n').lstrip('rootpw "').rstrip('"')


Florian Best @fbest · 2 days ago
.lstrip() removes all the characters! Therefore the password cannot start with any of 'rotpw '!
Comment 1 Felix Botner univentionstaff 2019-03-18 10:18:41 CET
fixed in univention-python
Comment 2 Florian Best univentionstaff 2019-03-18 15:51:40 CET
As Jürn will replace the function soon, this fix isn't really relevant for UCS 4.4.

OK: Code review
~OK: YAML (wording could be better)
Comment 3 Felix Botner univentionstaff 2019-03-18 15:54:19 CET
(In reply to Florian Best from comment #2)
> As Jürn will replace the function soon, this fix isn't really relevant for
> UCS 4.4.

with what?

please consider 

management/univention-ldap-overlay-memberof/univention-update-memberof:		lo = univention.uldap.getRootDnConnection()
Comment 4 Florian Best univentionstaff 2019-03-18 16:13:40 CET
(In reply to Felix Botner from comment #3)
> (In reply to Florian Best from comment #2)
> > As Jürn will replace the function soon, this fix isn't really relevant for
> > UCS 4.4.
> 
> with what?
ldap bind with SASL authentication using a local unix socket.

Afaics, the memberof thing should still work then.
Comment 5 Arvid Requate univentionstaff 2019-03-20 12:29:29 CET
<http://errata.software-univention.de/ucs/4.4/10.html>