Bug 49024 – getRootDnConnection broken

Bug 49024 - getRootDnConnection broken


Summary:	getRootDnConnection broken

Status:	CLOSED FIXED

Product:	UCS
Classification:	Unclassified
Component:	LDAP
Version:	UCS 4.4
Hardware:	Other Linux

Importance:	P5 normal (vote)
Target Milestone:	UCS 4.4-0-errata
Assigned To:	Felix Botner
QA Contact:	Florian Best

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2019-03-18 09:57 CET by Felix Botner
Modified:	2019-03-20 12:29 CET (History)
CC List:	0 users

See Also:
What kind of report is it?:	Development Internal
What type of bug is this?:	---
Who will be affected by this bug?:	---
How will those affected feel about the bug?:	---
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional):
Max CVSS v3 score:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Felix Botner

2019-03-18 09:57:33 CET

getRootDnConnection:

bindpw = open('/etc/ldap/rootpw.conf').read().rstrip('\n').lstrip('rootpw "').rstrip('"')


Florian Best @fbest · 2 days ago
.lstrip() removes all the characters! Therefore the password cannot start with any of 'rotpw '!

Comment 1 Felix Botner

2019-03-18 10:18:41 CET

fixed in univention-python

Comment 2 Florian Best

2019-03-18 15:51:40 CET

As Jürn will replace the function soon, this fix isn't really relevant for UCS 4.4.

OK: Code review
~OK: YAML (wording could be better)

Comment 3 Felix Botner

2019-03-18 15:54:19 CET

(In reply to Florian Best from comment #2)
> As Jürn will replace the function soon, this fix isn't really relevant for
> UCS 4.4.

with what?

please consider 

management/univention-ldap-overlay-memberof/univention-update-memberof:		lo = univention.uldap.getRootDnConnection()

Comment 4 Florian Best

2019-03-18 16:13:40 CET

(In reply to Felix Botner from comment #3)
> (In reply to Florian Best from comment #2)
> > As Jürn will replace the function soon, this fix isn't really relevant for
> > UCS 4.4.
> 
> with what?
ldap bind with SASL authentication using a local unix socket.

Afaics, the memberof thing should still work then.

Comment 5 Arvid Requate

2019-03-20 12:29:29 CET

<http://errata.software-univention.de/ucs/4.4/10.html>