Bug 25305 – [Process overview] SIGKILL/SIGTERM of not anymore running process causes traceback

Bug 25305 - [Process overview] SIGKILL/SIGTERM of not anymore running process causes traceback


Summary:	[Process overview] SIGKILL/SIGTERM of not anymore running process causes trac...

Status:	CLOSED FIXED

Product:	UCS
Classification:	Unclassified
Component:	UMC - Process overview
Version:	UCS 3.0
Hardware:	Other Linux

Importance:	P4 enhancement (vote)
Target Milestone:	UCS 4.0-1-errata
Assigned To:	Johannes Keiser
QA Contact:	Florian Best

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2011-12-08 11:26 CET by Lukas Walter
Modified:	2015-03-25 16:42 CET (History)
CC List:	5 users (show)

See Also:
What kind of report is it?:	---
What type of bug is this?:	---
Who will be affected by this bug?:	---
How will those affected feel about the bug?:	---
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional):	Error handling, External feedback, Usability
Max CVSS v3 score:

Flags:	klaeser: Patch_Available+

Attachments
patch (1.66 KB, patch) 2014-11-11 12:25 CET, Florian Best	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Lukas Walter

2011-12-08 11:26:09 CET

Das Prozessübersicht-Modul läd derzeit die Ansicht nicht neu, wenn ein Prozess terminiert wurde, weshalb dieser immernoch in der angezeigten Liste ist obwohl er nicht mehr läuft.
Der Nutzer hat daher die Möglichkeit erneut ein "Terminate/Force terminate" für den bereits beendeten Prozess durchzuführen, was jedoch zu dem folgenden Traceback führt:

==========================================================================
Execution of command 'top/kill' has failed:

Traceback (most recent call last):
File '/usr/lib/pymodules/python2.6/univention/management/console/modules/__init__.py', line 97, in execute
func( request )
File '/usr/lib/pymodules/python2.6/univention/management/console/modules/top/__init__.py', line 122, in kill
failed = ', '.join(failed)
TypeError: sequence item 0: expected string, int found
===========================================================================

(identisch für Terminat/Force terminate)

Comment 1 Dirk Wiesenthal

2012-12-06 16:58:04 CET

Das Grid sollte auf jeden Fall neu geladen werden. Der Fall muss aber trotzdem abgefangen werden (vielleicht ist der Prozess ja währenddessen auf anderem Wege beendet worden)

Comment 2 Philipp Hahn

2014-07-08 15:51:30 CEST

+1

Comment 3 Florian Best

2014-11-11 12:07:53 CET

Occurred again during the UCS 4.0 Product tests.

Comment 4 Florian Best

2014-11-11 12:25:15 CET

Created attachment 6338 [details]
patch

The attached patch fixes every issue:
* reload the grid after killing a process
* show a standby animation during killing a process
* fix the backend traceback so that a normal error message is displayed again

Comment 5 Florian Best

2015-03-10 08:48:37 CET

Reported by traceback feedback, 3.2-4 errata273 (Borgfeld)

Comment 6 Johannes Keiser

2015-03-17 14:01:28 CET

(In reply to Florian Best from comment #4)
> Created attachment 6338 [details]
> patch
> 
> The attached patch fixes every issue:
> * reload the grid after killing a process
> * show a standby animation during killing a process
> * fix the backend traceback so that a normal error message is displayed again

implemented patch:

r59116
univention-management-console-module-top (4.1.0-5)
* Bug #25305: prevent traceback when SIGKILL/SIGTERM is send to an
process that isn't running anymore

YAML: r59117

Comment 7 Florian Best

2015-03-17 14:36:29 CET

OK: error message is shown again
OK: standby animation during kill
OK: grid reload
OK: YAML

Comment 8 Janek Walkenhorst

2015-03-25 16:42:10 CET

<http://errata.univention.de/ucs/4.0/133.html>