Bug 28665 – Hinweis wenn Cookies nicht aktiviert sind

Bug 28665 - Hinweis wenn Cookies nicht aktiviert sind


Summary:	Hinweis wenn Cookies nicht aktiviert sind

Status:	CLOSED FIXED

Product:	UCS
Classification:	Unclassified
Component:	UMC (Generic)
Version:	UCS 4.1
Hardware:	Other Linux

Importance:	P5 normal (vote)
Target Milestone:	UCS 4.1-2-errata
Assigned To:	Jürn Brodersen
QA Contact:	Alexander Kläser

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2012-09-28 10:46 CEST by Alexander Kläser
Modified:	2016-08-03 15:56 CEST (History)
CC List:	2 users (show)

See Also:
What kind of report is it?:	---
What type of bug is this?:	---
Who will be affected by this bug?:	---
How will those affected feel about the bug?:	---
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional):	Usability
Max CVSS v3 score:

Flags:	klaeser: Patch_Available+

Attachments
proposed patch (3.40 KB, patch) 2016-05-13 16:03 CEST, Jürn Brodersen	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Alexander Kläser

2012-09-28 10:46:29 CEST

Es könnte hilfreich sein, bei der Anmeldung einen Hinweis einzublenden (ähnlich wie für http/https), wenn Cookies deaktiviert sind. Dies kann in JavaScript über navigator.cookieEnabled abgefragt werden.

Comment 1 Jürn Brodersen

2016-05-13 16:03:32 CEST

Created attachment 7663 [details]
proposed patch

Comment 2 Alexander Kläser

2016-06-06 13:22:06 CEST

(In reply to Jürn Brodersen from comment #1)
> Created attachment 7663 [details]
> proposed patch

Patch looks nice :) ! Please commit the change.

Little adjustment for the title:
"Please enable cookies"
"Bitte Cookies aktivieren"

... and for the message:
"Browser cookies are necessary for working with Univention Management Console. Please activate cookies in your browser."
"Browser-Cookies sind notwendig für die Arbeit mit Univention Management Console. Bitte aktivieren sie Cookies in Ihrem Browser."

Comment 3 Jürn Brodersen

2016-06-06 14:55:08 CEST

UCS4.1-2:

r69849: * Show a warning on the login page if cookies are disabled
r69850: YAML
Package: univention-management-console-frontend
Version: 5.0.63-44.1237.201606061440

Comment 4 Alexander Kläser

2016-07-01 16:09:14 CEST

IE 11 → FAILED
EDGE 13 → FAILED
Chromium 41 → OK
Safari → OK

Please check again for IE/Edge.

Comment 5 Jürn Brodersen

2016-07-05 09:58:07 CEST

UCS4.1-2:

r70822: * IE did not show the cookies disabled warning
r70823: YAML
Package: univention-management-console-frontend
Version: 5.0.63-46.1238.201607050936

Comment 6 Alexander Kläser

2016-07-05 13:35:29 CEST

(In reply to Jürn Brodersen from comment #5)
> UCS4.1-2:
> 
> r70822: * IE did not show the cookies disabled warning
> r70823: YAML
> Package: univention-management-console-frontend
> Version: 5.0.63-46.1238.201607050936

My tests with IE 11 and Edge 13 failed again. The cause for this is has('ie'):

               | IE 11 | Edge 13
---------------------------------
has('ie')      | false | false
has('trident') | true  | false
has('edge')    | false | true

Comment 7 Alexander Kläser

2016-07-05 13:35:57 CEST

As discussed, you can additionally check whether umcUsername or umcSessionID are set as cookies.

Comment 8 Florian Best

2016-07-05 13:36:59 CEST

(In reply to Alexander Kläser from comment #7)
> As discussed, you can additionally check whether umcUsername or umcSessionID
> are set as cookies.
I don't understand this. Checking for what?

Comment 9 Jürn Brodersen

2016-07-05 14:30:14 CEST

(In reply to Florian Best from comment #8)
> (In reply to Alexander Kläser from comment #7)
> > As discussed, you can additionally check whether umcUsername or umcSessionID
> > are set as cookies.
> I don't understand this. Checking for what?

If umcUsername is already set as a cookie -> cookies must be enabled.
If umUsername is not set, cookies might be disabled or the user was not logged in in the last ~90 days.

umcSessionID has a longer time until it expires but gets removed on a logout.

Comment 10 Jürn Brodersen

2016-07-05 14:31:19 CEST

UCS4.1-2:

r70830: * Check for existing cookie instead of IE
Package: univention-management-console-frontend
Version: 5.0.63-47.1239.201607051419

Comment 11 Alexander Kläser

2016-07-06 16:42:39 CEST

Changes: OK, works fine now also with IE11/Edge13
YAML file: OK, I adjusted the package version [r70857]

→ VERIFIED

Comment 12 Janek Walkenhorst

2016-08-03 15:56:25 CEST

<http://errata.software-univention.de/ucs/4.1/230.html>