Univention Bugzilla – Bug 29498
Grid reloads when having Superordinates
Last modified: 2013-11-19 06:41:58 CET
Wenn man in der Erweiterten Suche in einer UDM-Modul-Übersicht das "Übergeordnete Objekt" ändert, verändern sich die Knöpfe unten, aber das Grid bleibt so, wie es ist. Ich hatte mal einen Patch für ein ähnliches Problem geschrieben, das hatte sich dann aber anders lösen lassen. Vielleicht funktioniert er noch. (Man kann ihn wahrscheinlich nicht mit patch einspielen, weil ich gerade noch andere Sachen rausschneiden musste)
Created attachment 4853 [details] reload bei form.ready()
IMHO ist das OK so. Bei den anderen ComboBoxen verhält es sich ja auch so, man wählt aus und bei Klick auf "Suchen" werden die Ergebnisse aktualaisiert.
Das Verhalten ist momentan aber ziemlich verwirrend. Denn das Ändern des übergordneten Objekts ändert die Knöpfe unterhalb des Grids, nur nicht das Grid selbst. Dort ist dann zum Beispiel ein Knopf "Alle DNS-Zonen zeigen", obwohl momentan alle DNS-Zonen gezeigt werden. Ob sich überhaupt etwas ändern muss, kann man diskutieren, aber entweder beide Sachen (Grid und Grid-Knöpfe) oder nichts von beidem.
(In reply to comment #3) > Das Verhalten ist momentan aber ziemlich verwirrend. Denn das Ändern des > übergordneten Objekts ändert die Knöpfe unterhalb des Grids, nur nicht das Grid > selbst. > > Dort ist dann zum Beispiel ein Knopf "Alle DNS-Zonen zeigen", obwohl momentan > alle DNS-Zonen gezeigt werden. Ob sich überhaupt etwas ändern muss, kann man > diskutieren, aber entweder beide Sachen (Grid und Grid-Knöpfe) oder nichts von > beidem. OK, ja, das stimmt.
*** Bug 29557 has been marked as a duplicate of this bug. ***
We will not ship a UCS 3.1-2 release; the next UCS release will be UCS 3.2. As such, this bug is moved to the new target milestone.
The attached patch has already been applied. Seems to be fixed since 3.1-1...
(In reply to Dirk Wiesenthal from comment #7) > The attached patch has already been applied. Seems to be fixed since 3.1-1... Yes in commit 38123. The UCR variable autosearch should be evaluated, as it is being done in line 443: > var autoSearch = this._ucr['directory/manager/web/modules/' + this.moduleFlavor + '/search/autosearch'] || > this._ucr['directory/manager/web/modules/autosearch']; Changelog missing. → REOPENED
Initially created to fix the buttons of the bottom of the grid while changing the superordinate, this bug has become more general: Autosearch is not correctly evaluated: The grid filters as soon as the superordinate changes - which is at the beginning - even though autosearch=0. This has been fixed in: univention-management-console-module-udm 4.0.12-1.332.201308061333 The grid still filters() in the following cases: autosearch=1, clicking the "Up"-button, clicking on a superordinate in the grid itself. It does _not_ filter when autosearch=0 and changing the superordinate in the advanced search form. Changelog updated.
(In reply to Dirk Wiesenthal from comment #9) > Initially created to fix the buttons of the bottom of the grid while > changing the superordinate, this bug has become more general: > > Autosearch is not correctly evaluated: The grid filters as soon as the > superordinate changes - which is at the beginning - even though autosearch=0. > > This has been fixed in: > univention-management-console-module-udm 4.0.12-1.332.201308061333 > > The grid still filters() in the following cases: autosearch=1, clicking the > "Up"-button, clicking on a superordinate in the grid itself. It does _not_ > filter when autosearch=0 and changing the superordinate in the advanced > search form. Setting directory/manager/web/modules/autosearch=0, the query is nevertheless re-evaluated as soon as a new superordinate object has been added. → REOPENED > Changelog updated. Changelog → OK
(In reply to Alexander Kläser from comment #10) > (In reply to Dirk Wiesenthal from comment #9) > Setting directory/manager/web/modules/autosearch=0, the query is > nevertheless re-evaluated as soon as a new superordinate object has been > added. > → REOPENED > I do not think this should be fixed. At least not here. As far as I can see this has nothing to do with superordinates. It happens also with Computers or other UDM modules *once the grid was populated*. If you have autosearch=0 and you add a new DNS Forward Zone in a "clean" grid, it does not reload. It does, if you have searched for all objects before. The code is not in udm.js but in umc/widgets/Grid.js, beginning with "// FIXME: should not be needed anymore with Dojo 1.8". And I think it is triggered by moduleStore._genericMultiCmd. If this should be changed this would have to be done in another bug. But I think it is better left where it is. If someone has already searched and populated the grid and then adds a new item, he will want to see it immediately (same holds for "remove").
(In reply to Dirk Wiesenthal from comment #11) > I do not think this should be fixed. At least not here. As far as I can see > this has nothing to do with superordinates. It happens also with Computers > or other UDM modules *once the grid was populated*. > > If you have autosearch=0 and you add a new DNS Forward Zone in a "clean" > grid, it does not reload. It does, if you have searched for all objects > before. Agreed → VERIFIED
UCS 3.2 has been released: http://docs.univention.de/release-notes-3.2-en.html http://docs.univention.de/release-notes-3.2-de.html If this error occurs again, please use "Clone This Bug".