Bug 31371 - UVMM event loop resync/replacement
UVMM event loop resync/replacement
Status: CLOSED WORKSFORME
Product: UCS
Classification: Unclassified
Component: Virtualization - UVMM
UCS 3.1
Other Linux
: P5 normal (vote)
: ---
Assigned To: Erik Damrose
Philipp Hahn
:
Depends on:
Blocks: 31032 31370
  Show dependency treegraph
 
Reported: 2013-05-16 08:48 CEST by Philipp Hahn
Modified: 2023-03-25 06:55 CET (History)
1 user (show)

See Also:
What kind of report is it?: ---
What type of bug is this?: ---
Who will be affected by this bug?: ---
How will those affected feel about the bug?: ---
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional): Cleanup, Troubleshooting
Max CVSS v3 score:


Attachments
Event loop resync (7.59 KB, patch)
2013-05-16 08:48 CEST, Philipp Hahn
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Philipp Hahn univentionstaff 2013-05-16 08:48:36 CEST
Created attachment 5228 [details]
Event loop resync

UVMM copied the Python event loop implementation from
libvirt/examples/domain-events/events-python/event-test.py.
That implementation was updated to handle some more error cases.

UVMM should update its own copy of that and/or switch to the default event loop
implementation now provided by the libvirt-C-library itself.

The attached patch does a resync and removes several trailing ';'s in Python
code.
The change to opaque needs more investigation.
Comment 1 Erik Damrose univentionstaff 2014-01-31 12:08:36 CET
(In reply to Philipp Hahn from comment #0)
> UVMM should update its own copy of that and/or switch to the default event
> loop
> implementation now provided by the libvirt-C-library itself.

Bug #33845 and #34020 fixed uvmmd (UCS 3.2 and 3.1 respectively) to use the default event loop from the libvirt c lib. Nothing to do here.
Comment 2 Philipp Hahn univentionstaff 2014-01-31 13:06:14 CET
OK: src/univention/uvmm/eventloop.py is gone and replaced by libvirt.virEventRegisterDefaultImpl() and libvirt.virEventRunDefaultImpl().