Bug 32429 – squid/redirect not usable on UCS

Bug 32429 - squid/redirect not usable on UCS


Summary:	squid/redirect not usable on UCS

Status:	CLOSED FIXED

Product:	UCS
Classification:	Unclassified
Component:	Squid
Version:	UCS 3.1
Hardware:	Other Linux

Importance:	P5 normal (vote)
Target Milestone:	UCS 3.2-1-errata
Assigned To:	Felix Botner
QA Contact:	Arvid Requate

URL:
Keywords:

Depends on:
Blocks:	35908
	Show dependency tree / graph

Reported:	2013-08-29 12:49 CEST by Moritz Muehlenhoff
Modified:	2014-09-11 15:03 CEST (History)
CC List:	1 user (show)

See Also:
What kind of report is it?:	---
What type of bug is this?:	---
Who will be affected by this bug?:	---
How will those affected feel about the bug?:	---
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional):
Max CVSS v3 score:

Attachments
qa_32429.patch (1.75 KB, patch) 2014-04-07 18:37 CEST, Arvid Requate	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Moritz Muehlenhoff

2013-08-29 12:49:34 CEST

Support for squid/redirect was merged from UCS@school in UCS 3.0-1. However, the template cannot be used in UCS out of the box. In UCS setting the variable will fail out of the box, since univention-squid doesn't depend on squidguard (in contrast to ucs@school):

if configRegistry.get("squid/redirect") == "squidguard":
        print 'url_rewrite_program /usr/bin/squidGuard -c /etc/squid/squidGuard.conf'

The template should rather use 

        print 'url_rewrite_program configRegistry['squid/redirect'

so that other redirectors can be used as well.

Comment 1 Felix Botner

2014-02-28 14:28:57 CET

2014-02-28-univention-squid.yaml

"squid/redirect" is now simply the option for "url_rewrite_program" with the special case "squid/redirect=squidguard", then 'url_rewrite_program /usr/bin/squidGuard -c /etc/squid/squidGuard.conf' is still used (so we don't break ucs@school).

> In UCS setting the variable will fail out of the box, since univention-squid 
> doesn't depend on squidguard (in contrast to ucs@school):

I didn't added a dependency. The redirector has to be installed and configured manually.

Comment 2 Arvid Requate

2014-04-07 18:37:40 CEST

Created attachment 5858 [details]
qa_32429.patch

Maybe the UCR description should be adjusted to reflect the extended flexibility, see attached patch proposal.

Comment 3 Felix Botner

2014-04-08 12:13:24 CEST

(In reply to Arvid Requate from comment #2)
> Created attachment 5858 [details]
> qa_32429.patch
> 
> Maybe the UCR description should be adjusted to reflect the extended
> flexibility, see attached patch proposal.

fixed

Comment 4 Arvid Requate

2014-04-08 12:34:33 CEST

Ok.

Comment 5 Arvid Requate

2014-04-08 18:03:39 CEST

On a samba4 DC the joinscript now uses the common create_spn_account.sh script from univention-samba4.

To test this I messed up the password of the account and after running the joinscript again the create_spn_account.sh script created a new password so the existing account works again. On the other hand, if the account is present and the password works then it doesn't touch it.

Advisory OK.

Comment 6 Arvid Requate

2014-04-08 18:04:35 CEST

Last comment wasn't intendet to be committed to ths bug, ignore.

Comment 7 Moritz Muehlenhoff

2014-04-09 08:26:57 CEST

http://errata.univention.de/ucs/3.2/87.html