Bug 33092 – Missing error handling for archive upload

Bug 33092 - Missing error handling for archive upload


Summary:	Missing error handling for archive upload

Status:	CLOSED FIXED

Product:	UCS
Classification:	Unclassified
Component:	Sysinfo
Version:	UCS 3.2
Hardware:	Other Linux

Importance:	P5 normal (vote)
Target Milestone:	UCS 4.0-0-errata
Assigned To:	Florian Best
QA Contact:	Drees Dormann

URL:
Keywords:

Duplicates:	31199 (view as bug list)
Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2013-11-01 15:11 CET by Alexander Kläser
Modified:	2016-10-07 18:01 CEST (History)
CC List:	4 users (show)

See Also:	31192
What kind of report is it?:	---
What type of bug is this?:	---
Who will be affected by this bug?:	---
How will those affected feel about the bug?:	---
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional):	Usability
Max CVSS v3 score:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Alexander Kläser

2013-11-01 15:11:53 CET

In case the upload fails, the module process seems to fail due to missing error handling. In the UMC wizard, the standby animation stays for forever.

>   File "/usr/sbin/univention-management-console-module", line 112, in <module>
>     notifier.loop()
>   File "/usr/lib/pymodules/python2.6/notifier/nf_generic.py", line 284, in loop
>     step()
>   File "/usr/lib/pymodules/python2.6/notifier/nf_generic.py", line 271, in step
>     not __sockets[ cond ][ fd ]( sock_obj ):
>   File "/usr/lib/pymodules/python2.6/univention/management/console/protocol/modserver.py", line 129, in _recv
>     data = socket.recv( RECV_BUFFER_SIZE )
> error: [Errno 104] Die Verbindung wurde vom Kommunikationspartner zur?ckgesetzt

Comment 1 Florian Best

2014-08-29 09:48:59 CEST

When any error occurs in the module the module just answers with "module process error, error message of the server was: None".
e.g. if the server (forge) is unreachable, or the upload fails, ...

Instead the reason should be printed. The standby animation should stop. Tracebacks should be logged. And in some cases a traceback would also be good so that the user can instead first sent that to univention. It sucks if error reporting fails.

Comment 2 Florian Best

2014-12-18 13:46:44 CET

I fixed the error handling during working on univention-system-info.
* Standby animations are reset if an error occurs
* It's not possible anymore to use various filesystem paths for the upload (e.g. /etc/shadow or /etc/ldap.secret).
* Errors are logged and sent to the frontend in a more user friendly way

Fix: svn r56968, svn r56969
YAML: 2014-12-18-univention-system-info.yaml

Comment 3 Drees Dormann

2014-12-18 16:27:43 CET

fixed ,

error handling looks good
Upon failure Page now shows "Update failed"

YAML OK

Comment 4 Janek Walkenhorst

2014-12-19 11:47:57 CET

http://errata.univention.de/ucs/4.0/11.html

Comment 5 Florian Best

2016-10-07 18:01:17 CEST

*** Bug 31199 has been marked as a duplicate of this bug. ***