Bug 34145 – Change app center black-/whitelisting to include appid filter

Bug 34145 - Change app center black-/whitelisting to include appid filter


Summary:	Change app center black-/whitelisting to include appid filter

Status:	CLOSED FIXED

Product:	UCS
Classification:	Unclassified
Component:	UMC - App-Center
Version:	UCS 3.2
Hardware:	Other Linux

Importance:	P5 normal (vote)
Target Milestone:	UCS 3.2-1-errata
Assigned To:	Dirk Wiesenthal
QA Contact:	Erik Damrose

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2014-02-18 11:57 CET by Erik Damrose
Modified:	2014-02-27 12:58 CET (History)
CC List:	3 users (show)

See Also:
What kind of report is it?:	---
What type of bug is this?:	---
Who will be affected by this bug?:	---
How will those affected feel about the bug?:	---
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional):
Max CVSS v3 score:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Erik Damrose

2014-02-18 11:57:27 CET

We should improve the black- and whitelisting functionality in the app center. 

Currently, the filter looks for app _names_ and category _names_. However, this is done after translating each of the values. In order to filter an app, all translations have to be added to the black or whitelist. 

We should at least add filtering based on the app id. Filtering based on translated app or category names is error-prone and should be removed.

Comment 1 Dirk Wiesenthal

2014-02-25 11:18:10 CET

Fixed in univention-management-console-module-appcenter 3.0.51-3.237.201402251033

The blacklist and whitelist now uses: app.id, app.unlocalised_name, app.unlocalised_categories

Comment 2 Erik Damrose

2014-02-25 17:46:45 CET

Change: OK; Filtering works as expected. Currently available appliances are not affected.

FAIL: The code comments are now wrong. Please remove the "(by name and by category)" parts (line 668 & 674 in app_center.py) and expand the comment for the _included method. I think this is rather important, as it is the only documentation available what these ucr variables filter. Bonus points will be distributed if a proper ucr variable description is added.

yaml: OK

Comment 3 Dirk Wiesenthal

2014-02-26 11:02:37 CET

I want the bonus points!

  univention-management-console-module-appcenter 3.0.51-4.238.201402261011

Comment 4 Erik Damrose

2014-02-27 09:24:07 CET

OK: No code changes
OK: Comments
OK: yaml
-> Verified

(In reply to Dirk Wiesenthal from comment #3)
> I want the bonus points!

You will get them

Comment 5 Janek Walkenhorst

2014-02-27 12:58:34 CET

http://errata.univention.de/ucs/3.2/63.html