Bug 35471 - remove special handling of wizard mode in pages
remove special handling of wizard mode in pages
Status: RESOLVED WORKSFORME
Product: UCS
Classification: Unclassified
Component: UMC - Basic settings
UCS 3.2
Other Linux
: P5 normal (vote)
: UCS 3.x
Assigned To: UMC maintainers
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-07-25 10:46 CEST by Florian Best
Modified: 2014-11-25 11:26 CET (History)
1 user (show)

See Also:
What kind of report is it?: ---
What type of bug is this?: ---
Who will be affected by this bug?: ---
How will those affected feel about the bug?: ---
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional): Cleanup
Max CVSS v3 score:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Florian Best univentionstaff 2014-07-25 10:46:06 CEST
There is a lot of special handling for the wizard mode in the system setup pages. As these pages aren't used in the wizard mode anymore the code can be very much simplified, workarounds removed, network restrictions reverted. The general complexity of the code can be simplified.

BasisPage.js
50:             wizard_mode: false,
166:                    _set('fqdn', !this.wizard_mode && role != 'basesystem', true, this.wizard_mode && this._firstSetValues);
167:                    _set('windows/domain', !this.wizard_mode && role != 'basesystem', role != 'basesystem', this.wizard_mode && this._firstSetValues, role == 'domaincontroller_master' || role == 'basesystem');
168:                    _set('ldap/base', !this.wizard_mode && role != 'basesystem', role != 'basesystem', this.wizard_mode && this._firstSetValues, role == 'domaincontroller_master' || role == 'basesystem');
169:                    _set('root_password', false, this.wizard_mode && this.local_mode);
171:                    if (role == 'domaincontroller_master' && this.wizard_mode) {
181:                    if (role == 'domaincontroller_master' && this.wizard_mode) {

InterfaceWizard.js
55:             wizard_mode: null,
109:                                                    if (this.wizard_mode) {
466:                    if (this.wizard_mode) {

CertificatePage.js
48:             wizard_mode: false,
153:                    if (this.wizard_mode) {
178:                    this._doShowNote = !this.wizard_mode;

NetworkPage.js
54:             wizard_mode: false,
153:                    this._form._widgets.interfaces.set('wizard_mode', this.wizard_mode);
229:                    this._form.getWidget('nameserver').set('visible', ! ( this.wizard_mode && this._currentRole == 'domaincontroller_master' ) );
235:                    if (!this.wizard_mode && !this._interfacesWatchHandler) {

InterfaceGrid.js
49:             wizard_mode: null,
310:                    if (this.wizard_mode) {
353:                            wizard_mode: this.wizard_mode,

LanguagePage.js
51:             wizard_mode: false,
171:                    if (this.wizard_mode && this._firstSetValues) {
190:                    if (this.wizard_mode && this._firstSetValues) {
Comment 1 Florian Best univentionstaff 2014-07-25 10:47:26 CEST
especially Bug #33991
Comment 2 Florian Best univentionstaff 2014-11-25 11:26:54 CET
I fixed all these things in UCS 4.0.