Bug 36771 - grid tooltips are aggressive
grid tooltips are aggressive
Status: CLOSED FIXED
Product: UCS
Classification: Unclassified
Component: UMC (Generic)
UCS 4.0
Other Linux
: P5 normal (vote)
: UCS 4.0-2-errata
Assigned To: Drees Dormann
Alexander Kläser
:
: 36461 (view as bug list)
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-11-17 17:58 CET by Florian Best
Modified: 2015-08-06 17:54 CEST (History)
6 users (show)

See Also:
What kind of report is it?: ---
What type of bug is this?: ---
Who will be affected by this bug?: ---
How will those affected feel about the bug?: ---
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional): External feedback, Usability
Max CVSS v3 score:


Attachments
tooltip while adding uvmm iso image (41.66 KB, image/png)
2015-04-02 10:14 CEST, Erik Damrose
Details
tooltip @school file upload button (8.09 KB, image/png)
2015-04-02 22:42 CEST, Michael Grandjean
Details
Screenshot (33.32 KB, image/png)
2015-07-13 11:30 CEST, Florian Best
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Florian Best univentionstaff 2014-11-17 17:58:27 CET
The tooltips in the computerroom module grid are aggressive and disturbs the context menu actions.
Comment 1 Sönke Schwardt-Krummrich univentionstaff 2014-11-17 20:44:17 CET
This is annoying but it only happens, when the cursor is on the hostname field. It does not happen, if the cursor is e.g. on the username field.
→ Workaround: press right mouse button on the user name field
Comment 2 Alexander Kläser univentionstaff 2014-11-20 15:22:13 CET
This should be a generic UMC issue.
Comment 3 Alexander Kläser univentionstaff 2014-11-20 15:22:23 CET
Screenshot?
Comment 4 Sönke Schwardt-Krummrich univentionstaff 2014-11-24 09:25:13 CET
(In reply to Alexander Kläser from comment #3)
> Screenshot?

The tooltips are working normally but are popping up quite fast and are positioned below the currently selected line. So the tooltip is overlaying the following lines in the grid. When moving down to the next grid line, not the line but the tooltip of the previous line is selected → the tooltip does not disappear.

I think the tooltips should be shown left/right of the selected line.
Comment 5 Alexander Kläser univentionstaff 2015-04-02 09:32:21 CEST
Another example is the upload widget in the distribution module.
Comment 6 Erik Damrose univentionstaff 2015-04-02 10:14:54 CEST
Created attachment 6797 [details]
tooltip while adding uvmm iso image

The tooltip also is in the way when selecting an ISO image in uvmm. Screenshot attached
Comment 7 Alexander Kläser univentionstaff 2015-04-02 12:10:01 CEST
*** Bug 36461 has been marked as a duplicate of this bug. ***
Comment 8 Michael Grandjean univentionstaff 2015-04-02 22:42:50 CEST
Created attachment 6805 [details]
tooltip @school file upload button

This also applies to the "Upload" button of the "Distribute materials" module in UCS@school. The button is almost completey covered by a tooltip (screenshot attached).

In a UCS@school workshop today, 3 out of 5 attendees had quite some trouble to 
add files at all (clicking three times on the button/tooltip fast enough seems to work somehow). A fourth attendee gave up.
Comment 9 Alexander Kläser univentionstaff 2015-05-22 11:22:00 CEST
Is also mentioned at Ticket#2015051321000257.
Comment 10 Drees Dormann univentionstaff 2015-07-07 08:21:57 CEST
I changed the behaviour of the tooltips, they will no longer automatically pop up. To display a tooltip the new tooltip icon must be clicked.

Also added a test site for the tooltip wich is still work in progress.
Comment 11 Florian Best univentionstaff 2015-07-13 11:30:36 CEST
Created attachment 7021 [details]
Screenshot
Comment 12 Florian Best univentionstaff 2015-07-13 11:31:28 CEST
(In reply to Florian Best from comment #11)
> Created attachment 7021 [details]
> Screenshot
Some content is stripped. The tooltip for the edit button if also not really nice.
Comment 13 Drees Dormann univentionstaff 2015-07-17 11:46:11 CEST
Tooltips were displayed for hidden labels, this is now fixed.
Changes have been merged to 4.1-0 branch.
Comment 14 Florian Best univentionstaff 2015-07-17 12:08:38 CEST
There are no tooltips on hover anymore for the mentioned buttons.
Comment 15 Drees Dormann univentionstaff 2015-07-23 10:15:03 CEST
Restored old tooltip style for buttons, all other tooltips will default to new style.
Old style can be used if falg 'usesHoverTooltip' is set on widget.
Comment 16 Drees Dormann univentionstaff 2015-07-27 11:02:11 CEST
Fixed a missing flag which resulted in tooltips not beeing displayed for some buttons
Comment 17 Alexander Kläser univentionstaff 2015-07-28 17:11:42 CEST
I updated the test html page and observed the following misbehavior:
* 1st MultiInput: adding a new entry does not show a tooltip.
* 2nd MultiInput: the first field of the first entry does not obtain the description of the subtype.
* 2nd Uploader: without label, the tooltip should be bound directly to the upload button.
* Should not the tooltip node disappear if the label/description is set to an empty value?
* Button: tooltip should be bound directly to the button itself.

univention-management-console-frontend (4.1.106-81):
r62483 | Bug #36771: updated tooltip test page
Comment 18 Drees Dormann univentionstaff 2015-07-31 12:09:47 CEST
All issues have been addressed,
button and uploader will now handle the tooltip on their own.
Comment 19 Alexander Kläser univentionstaff 2015-07-31 14:06:13 CEST
Looks nice, cool!
One little think that I spotted, if I set the description to "", the previous tooltip is still shown for the Uploader/Button widgets.
Comment 20 Alexander Kläser univentionstaff 2015-07-31 14:12:44 CEST
I guess a CSS rule similar to the following is missing to fix a right alignment of the tooltip:

.dijitTooltipABRight .dijitTooltipConnector {
  right: 4px;
}
Comment 21 Alexander Kläser univentionstaff 2015-07-31 14:24:10 CEST
The version 4.1.106-85.1082.201507311156 seems to be broken, as dojo.js is empty. This is due to the comma after _setDescriptionAttr() in Button.js.

Can you please rename tooltip to _tooltip in Button/Uploader.
Comment 22 Drees Dormann univentionstaff 2015-07-31 15:11:00 CEST
I removed the ',' so build should be fine.
CSS rule has been added.
in addition setting the description of tooltips for uploader and button should work correct now.
Comment 23 Alexander Kläser univentionstaff 2015-07-31 16:22:11 CEST
(In reply to Drees Dormann from comment #22)
> I removed the ',' so build should be fine.

OK!

> CSS rule has been added.

OK, cool!

> in addition setting the description of tooltips for uploader and button
> should work correct now.

Nope :) . I debugged the Tooltip class a bit. You do not need to destroy the tooltip, instead, simply set its label to '' and it will not show up anymore. It seems that the registration mechanism even after destroying a tooltip is still working.
Comment 24 Drees Dormann univentionstaff 2015-08-03 08:37:28 CEST
Uploader and button widget have been adapted
Comment 25 Alexander Kläser univentionstaff 2015-08-05 08:35:12 CEST
(In reply to Drees Dormann from comment #24)
> Uploader and button widget have been adapted

OK, this looks fine now.

I think we need to adapt the padding for checkboxes, but let's do this in a next step.

→ VERIFIED
Comment 26 Janek Walkenhorst univentionstaff 2015-08-06 17:51:22 CEST
<http://errata.univention.de/ucs/4.0/268.html>
Comment 27 Janek Walkenhorst univentionstaff 2015-08-06 17:54:48 CEST
<http://errata.univention.de/ucs/4.0/266.html>