Bug 37169 - provide more information in traceback feedback
provide more information in traceback feedback
Status: CLOSED FIXED
Product: UCS
Classification: Unclassified
Component: UMC (Generic)
UCS 4.0
Other Linux
: P5 normal (vote)
: UCS 4.0-0-errata
Assigned To: Florian Best
Dirk Wiesenthal
:
Depends on:
Blocks: 37366
  Show dependency treegraph
 
Reported: 2014-12-04 00:54 CET by Florian Best
Modified: 2015-01-22 11:54 CET (History)
2 users (show)

See Also:
What kind of report is it?: ---
What type of bug is this?: ---
Who will be affected by this bug?: ---
How will those affected feel about the bug?: ---
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional):
Max CVSS v3 score:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Florian Best univentionstaff 2014-12-04 00:54:18 CET
By default the following information are really helpful for the traceback feedback:
* flavor
* UMCP command
* (request options without sensitive information)
* (response status)
* traceback

The internal error handling should be unified so that UMC-Server + UMC-Modules + Threaded-Methods all use the same error handling function.

The status codes which differentiate a UMC-Module error and a UMC-Server error are not necessary. The real HTTP status code 500 should be used.

A unified format of the JSON error response could be implemented for errors. Currently everything is a string using the "message" attribute of the UMCP response. Status titles are generated by the frontend, this is the job of the backend (errors should be viewable independent of the user agent software).
Comment 1 Florian Best univentionstaff 2014-12-04 13:55:08 CET
Replace "/usr/lib/pymodules/python2.6/" with "%PY2.6%"
→ tracebacks pasted into bugzilla/OTRS are faster to read
Comment 2 Florian Best univentionstaff 2014-12-08 11:59:01 CET
* server/role
* logged_in_user == 'Administrator'
Comment 3 Florian Best univentionstaff 2014-12-08 13:15:13 CET
create a hash of the tracebacks (stripping line numbers, whitespace, python-version, etc.)
Comment 4 Florian Best univentionstaff 2014-12-08 13:17:33 CET
* ad/member
* samba_installed
Comment 5 Stefan Gohmann univentionstaff 2014-12-08 15:14:01 CET
We should discuss the changes before something will be implemented or released.
Comment 6 Florian Best univentionstaff 2014-12-16 16:47:22 CET
(In reply to Stefan Gohmann from comment #5)
> We should discuss the changes before something will be implemented or
> released.
As discussed with Stefan:
It is okay to provide the following information, they should be visible for the reporter:
* UMCP-command
* UMCP-flavor
* Traceback

The server/role, etc. should not be sent.

In our traceback-receive-script on forge we should implement comment #3. This will save some time searching for tracebacks. In the future it's possible to automatically relate tracebacks to bug numbers/etc.
Comment 7 Florian Best univentionstaff 2014-12-16 16:50:56 CET
The error handling things have been moved into Bug #37366.
Comment 8 Florian Best univentionstaff 2015-01-05 18:29:04 CET
A unique hash of the traceback is now generated when we reseive the traceback. The package need to be updated on forge.univention.de. No YAML required as it is a internal package.
Package: univention-system-info-traceback
Version: 1.0.0-2.2.201501051513
Branch: ucs_3.0-0
Scope: internal
Fix: svn r57081 (build a unique hash for tracebacks)


Adding the flavor to the error information. One liner fix. As UDM uses the error handling function from the UMC server core for threads it was enough to fix it there. Bug #37366 will implement the rest.
Fix: r57087
YAML: 2014-12-04-univention-management-console.yaml
Package: univention-management-console
Version: 7.1.63-10.851.201501051823
Branch: ucs_4.0-0
Scope: errata4.0-0
Comment 9 Florian Best univentionstaff 2015-01-09 09:58:49 CET
If we ever want to add some more information it would also be interesting to know what browser was used.
Comment 10 Dirk Wiesenthal univentionstaff 2015-01-13 12:36:15 CET
OK, flavor is added.

univention-system-info-traceback also works nicely.
Comment 11 Janek Walkenhorst univentionstaff 2015-01-22 11:54:52 CET
<http://errata.univention.de/ucs/4.0/44.html>