Bug 39033 - Browser history back/next buttons are not correctly integrated
Browser history back/next buttons are not correctly integrated
Status: CLOSED FIXED
Product: UCS
Classification: Unclassified
Component: UMC - Domain management (Generic)
UCS 4.1
Other Linux
: P5 enhancement (vote)
: UCS 4.1
Assigned To: Alexander Kläser
Florian Best
: interim-2
: 39555 (view as bug list)
Depends on: 20714
Blocks: 39840
  Show dependency treegraph
 
Reported: 2015-07-28 13:51 CEST by Alexander Kläser
Modified: 2015-11-17 12:11 CET (History)
3 users (show)

See Also:
What kind of report is it?: ---
What type of bug is this?: ---
Who will be affected by this bug?: ---
How will those affected feel about the bug?: ---
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional): External feedback, Usability
Max CVSS v3 score:


Attachments
Patch for UDM module (2.26 KB, patch)
2015-07-28 13:51 CEST, Alexander Kläser
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander Kläser univentionstaff 2015-07-28 13:51:27 CEST
Created attachment 7058 [details]
Patch for UDM module

I attached a patch to integrated the back/next history navigation into the UDM module. It also works for opening modules in a new tab. The only current problem is that the module header title is not updated when switching from a detail page back to the search page.

@Florian: Do you have an idea w.r.t. the module title.

+++ This bug was initially created as a clone of Bug #20714 +++

Wird in der UMC per Browse-History (vor/zurück) zu früheren Seiten gesprungen, so wird dies nicht korrekt im Web-Interface erkannt und stattdessen eine ältere Seite als "aktuell" angesehen.

Beispiele:
a) Ein Klick auf Icon "System-Statistiken", dann History-Zurück, dann auf "Prozessübersicht" führt wieder zu "System-Statistiken"
b) Ein Klcik auf Reiter "Wizards", dann History-Zurück, dann auf "System-Statistiken" führt zu "Nagios-Konfiguration"
Comment 1 Alexander Kläser univentionstaff 2015-07-28 13:52:58 CEST
Patch has been applied:

univention-management-console-module-udm (5.1.25-80):
r62464 | Bug #39033: integrated browser history navigation into UDM module
Comment 2 Alexander Kläser univentionstaff 2015-07-28 13:57:12 CEST
Bumped the package version

univention-management-console-module-udm (6.0.0-1):
r62465 | Bug #39033: version bump for 4.1
r62464 | Bug #39033: integrated browser history navigation into UDM module
Comment 3 Florian Best univentionstaff 2015-08-13 18:53:56 CEST
It would be nice if a logout would clear the hash. Otherwise one opens a module, logs out, logs in as another user and it tries to open that same module.
Comment 4 Florian Best univentionstaff 2015-10-17 21:03:40 CEST
(In reply to Florian Best from comment #3)
> It would be nice if a logout would clear the hash. Otherwise one opens a
> module, logs out, logs in as another user and it tries to open that same
> module.
→ I fixed this during working on SAML.

Please at a changelog entry.
Comment 5 Florian Best univentionstaff 2015-10-22 12:02:18 CEST
*** Bug 39555 has been marked as a duplicate of this bug. ***
Comment 6 Florian Best univentionstaff 2015-10-22 12:03:06 CEST
(In reply to Florian Best from comment #5)
> *** Bug 39555 has been marked as a duplicate of this bug. ***
This seems to be a side effect of svn r62464
Comment 7 Johannes Keiser univentionstaff 2015-10-30 11:57:38 CET
(In reply to Florian Best from comment #6)
> (In reply to Florian Best from comment #5)
> > *** Bug 39555 has been marked as a duplicate of this bug. ***
> This seems to be a side effect of svn r62464

This currently also breaks the App Center search in German as umlauts are escaped in Firefox.
Comment 8 Florian Best univentionstaff 2015-10-31 02:25:56 CET
The "Do you really want to install ...?" page resets the hash to the regular appcenter overview page. imho this should remain to the app detail page.
Comment 9 Alexander Kläser univentionstaff 2015-11-08 03:40:28 CET
(In reply to Florian Best from comment #6)
> (In reply to Florian Best from comment #5)
> > *** Bug 39555 has been marked as a duplicate of this bug. ***
> This seems to be a side effect of svn r62464

(In reply to Johannes Keiser from comment #7)
> (In reply to Florian Best from comment #6)
> > (In reply to Florian Best from comment #5)
> > > *** Bug 39555 has been marked as a duplicate of this bug. ***
> > This seems to be a side effect of svn r62464
> 
> This currently also breaks the App Center search in German as umlauts are
> escaped in Firefox.

Problems with encoding (relevant for App Center in German [→Verfügbare Apps] and for UDM objects containing a special character in the DN) have been fixed.

univention-management-console-frontend (5.0.59-1):
r65307 | Bug #39033: handle encoding problems with hashes on Firefox

(In reply to Florian Best from comment #8)
> The "Do you really want to install ...?" page resets the hash to the regular
> appcenter overview page. imho this should remain to the app detail page.

True, however, this does not break anything right now... so I would rather leave it like this at the moment. Feel free to open a new bug.


I spotted two other problems:

(1) Consider the following actions
* Open user A
* Close detail view
* Open user B
* History back → leads to the search page
* History back → led to user B, however, it should lead to user A

(2) I observed that opening a URL containing a user DN would sometimes not work. I also observed that "[Object Deferred]" popped up in the URL.

I corrected both problems.

univention-management-console-module-udm (6.0.7-1):
r65308 | Bug #39033: Fix switching UDM objects + LDAP name may be a Deferred

A changelog entry has been added:
r65309 | Bug #39033: add changelog entry
Comment 10 Alexander Kläser univentionstaff 2015-11-08 03:48:01 CET
(In reply to Alexander Kläser from comment #9)
> ...
> (2) I observed that opening a URL containing a user DN would sometimes not
> work. I also observed that "[Object Deferred]" popped up in the URL.
> 
> I corrected both problems.
> 
> univention-management-console-module-udm (6.0.7-1):
> r65308 | Bug #39033: Fix switching UDM objects + LDAP name may be a Deferred

The second problem can still be reproduced on FF. Let's open a new bug for this one.
Comment 11 Alexander Kläser univentionstaff 2015-11-08 03:58:26 CET
(In reply to Alexander Kläser from comment #10)
> (In reply to Alexander Kläser from comment #9)
> > ...
> > (2) I observed that opening a URL containing a user DN would sometimes not
> > work. I also observed that "[Object Deferred]" popped up in the URL.
> > 
> > I corrected both problems.
> > 
> > univention-management-console-module-udm (6.0.7-1):
> > r65308 | Bug #39033: Fix switching UDM objects + LDAP name may be a Deferred
> 
> The second problem can still be reproduced on FF. Let's open a new bug for
> this one.

Please do not ask why, but the following change did work for me.

univention-management-console-module-udm (6.0.7-2):
r65310 | Bug #39033: fix opening UDM objects directly via URI
Comment 12 Florian Best univentionstaff 2015-11-11 17:26:26 CET
OK: case 1
OK: case 2
OK: opening of objects with special characters in its identifier
OK: Changelog
Comment 13 Stefan Gohmann univentionstaff 2015-11-17 12:11:30 CET
UCS 4.1 has been released:
 https://docs.software-univention.de/release-notes-4.1-0-en.html
 https://docs.software-univention.de/release-notes-4.1-0-de.html

If this error occurs again, please use "Clone This Bug".