Bug 40116 - Simplify app detail view in small domains
Simplify app detail view in small domains
Status: CLOSED FIXED
Product: UCS
Classification: Unclassified
Component: UMC - App-Center
UCS 4.1
Other Linux
: P5 normal (vote)
: UCS 4.1-0-errata
Assigned To: Alexander Kramer
Alexander Kläser
:
: 39897 (view as bug list)
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2015-11-26 17:18 CET by Alexander Kläser
Modified: 2016-02-04 14:10 CET (History)
3 users (show)

See Also:
What kind of report is it?: ---
What type of bug is this?: ---
Who will be affected by this bug?: ---
How will those affected feel about the bug?: ---
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional): Design, Usability
Max CVSS v3 score:


Attachments
Doubled installation button (29.97 KB, image/png)
2015-11-26 18:22 CET, Alexander Kläser
Details
Patch without de.po (20.89 KB, patch)
2015-12-10 08:15 CET, Alexander Kramer
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander Kläser univentionstaff 2015-11-26 17:18:13 CET
The following aspects are yet to be improved in the detail view of an app, especially w.r.t. the usability in small domains (e.g., only 1 DC Master):

* The button "Install" should be removed if there is no server where the app can
  be installed or if the domain-wide mode is switched off. (Currently,
  "Install" can be triggered, but the drop down is empty.)

* The grid could be replaced with a list of buttons if the domain consists only
  of 1 DC Master, or if the domain-wide mode is switched off.

* Maybe the grid can be hidden and only shown when pressing on a button "Manage
  this app on other systems".
Comment 1 Alexander Kläser univentionstaff 2015-11-26 18:22:49 CET
Created attachment 7322 [details]
Doubled installation button

... when I open the DHCP server component, there is no "Install" button, only a "Open" button. I guess we should in this case here remove the "Install" button completely.
Comment 2 Alexander Kläser univentionstaff 2015-11-30 13:29:04 CET
(In reply to Alexander Kläser from comment #0)
> ...
> * The grid could be replaced with a list of buttons if the domain consists
>   only of 1 DC Master, or if the domain-wide mode is switched off.

cf., UCR variable appcenter/domainwide.
Comment 3 Stefan Gohmann univentionstaff 2015-12-02 10:39:20 CET
*** Bug 39897 has been marked as a duplicate of this bug. ***
Comment 4 Alexander Kramer univentionstaff 2015-12-10 08:15:10 CET
Created attachment 7360 [details]
Patch without de.po

As discussed the patch includes the following changes:

- the app name is now displayed in the module header

- the layout of the icon and the nav buttons has been adapted. The app vendor name and the status are now below the icon - left to the buttons.

- if no app.vendor is given app.maintainer is used as fall back

- the icon got an max-width of 550px which makes the site more restful

- if only one dc exists or app.docker is true or appcenter/domainwide is false
-- only actions buttons are visible to manage the local installation
-- in this case the header says 'local installation' instead of 'domain wide'
-- if the app is installed the 'install' button will not be rendered

- if a domain wide installation is possible the user still gets an grid to manage the apps

- if moduleID is not 'appcenter' the app categories inside the footer are not rendered as links any more

FYI: The patch does not include the diff for umc/js/de.po to keep it clear. So you have to generate the file before building the package.
Comment 5 Alexander Kramer univentionstaff 2015-12-10 12:15:45 CET
r66249
As requested I applied the patch and added the necessary translation.

Package: univention-appcenter
Version: 5.0.19-20.79.201512101207
Branch: ucs_4.1-0
Scope: errata4.1-0

r66250
yaml file
Comment 6 Alexander Kramer univentionstaff 2015-12-10 13:41:56 CET
r66258
univention-appcenter (5.0.19-23) 
* Bug #40116: Show grid also for docker apps
use already loaded apps for moduleState

Successful build
Package: univention-appcenter
Version: 5.0.19-23.83.201512101339
Branch: ucs_4.1-0
Scope: errata4.1-0
Comment 7 Alexander Kläser univentionstaff 2015-12-16 18:33:04 CET
I suggest to exchange the following headline:
"Manage local installation" → "Further actions for this app"
Comment 8 Alexander Kläser univentionstaff 2015-12-16 19:31:03 CET
Another thing that I spotted: Initially I had a DC master with installed ownCloud. When I added a DC slave with IP address to the domain (just the UDM object), the grid view appeared. However, the installed ownCloud (v8.2) would not allow to install another instance on the slave, where the (not installed) ownCloud v8.1 would give me the option to chose the DC slave for installation.
Comment 9 Alexander Kläser univentionstaff 2015-12-16 19:43:15 CET
(In reply to Alexander Kramer from comment #4)
> Created attachment 7360 [details]
> Patch without de.po
> 
> As discussed the patch includes the following changes:
> 
> - the app name is now displayed in the module header

OK.

> - the layout of the icon and the nav buttons has been adapted. The app
> vendor name and the status are now below the icon - left to the buttons.

Cool :) .

> - if no app.vendor is given app.maintainer is used as fall back

OK.

> - the icon got an max-width of 550px which makes the site more restful

OK.

> - if only one dc exists or app.docker is true or appcenter/domainwide is
> false

The logic should be:
> - if only one dc exists or !appcenter/domainwide
... as a containerized app can still be installed remotely. On the local machine, there is just an addition button for the configuration (i.e., this action can only be done on the local server).

> -- only actions buttons are visible to manage the local installation
> -- in this case the header says 'local installation' instead of 'domain wide'
> -- if the app is installed the 'install' button will not be rendered

OK.

> - if a domain wide installation is possible the user still gets an grid to
> manage the apps

OK.

> - if moduleID is not 'appcenter' the app categories inside the footer are
> not rendered as links any more

OK.
Comment 10 Alexander Kramer univentionstaff 2015-12-17 18:13:37 CET
(In reply to Alexander Kläser from comment #9)
> The logic should be:
> > - if only one dc exists or !appcenter/domainwide
> ... as a containerized app can still be installed remotely. On the local
> machine, there is just an addition button for the configuration (i.e., this
> action can only be done on the local server).

Done with r66258 compare with comment 6


And as requested the grid provides now an install and open action button.
r66452
univention-appcenter (5.0.19-32) 
* Bug #40116: Provide install and open action button to manage domain wide

Successful build
Package: univention-appcenter
Version: 5.0.19-32.90.201512171810
Branch: ucs_4.1-0
Scope: errata4.1-0
Comment 11 Dirk Wiesenthal univentionstaff 2015-12-18 02:24:08 CET
http://10.200.4.50/univention-management-console/#module=appcenter:appcenter:0:id:privacyidea shows a "undefined" title during StandBy while loading the App. Is this bug responsible for that? Not a show stopper, but easy to fix? set('title', val || 'App Center')?
Comment 12 Alexander Kläser univentionstaff 2015-12-18 12:22:42 CET
(In reply to Dirk Wiesenthal from comment #11)
> http://10.200.4.50/univention-management-console/#module=appcenter:appcenter:
> 0:id:privacyidea shows a "undefined" title during StandBy while loading the
> App. Is this bug responsible for that? Not a show stopper, but easy to fix?
> set('title', val || 'App Center')?

Good point!
Comment 13 Alexander Kramer univentionstaff 2015-12-21 08:52:57 CET
(In reply to Dirk Wiesenthal from comment #11)
> http://10.200.4.50/univention-management-console/#module=appcenter:appcenter:
> 0:id:privacyidea shows a "undefined" title during StandBy while loading the
> App. Is this bug responsible for that? Not a show stopper, but easy to fix?
> set('title', val || 'App Center')?

r66483
univention-appcenter (5.0.19-35) 
* Bug #40116: Show 'App Center' instead of undefined inside module header

Successful build
Package: univention-appcenter
Version: 5.0.19-35.93.201512210832
Branch: ucs_4.1-0
Scope: errata4.1-0
Comment 14 Alexander Kramer univentionstaff 2016-01-14 10:19:11 CET
Don't show 'Open' Button twice if isSingleServerInstallation
Comment 15 Alexander Kramer univentionstaff 2016-01-14 10:24:21 CET
r 66780
univention-appcenter (5.0.19-41) 
* Bug #40116: Don't show open button twice if isSingleServerInstallation

Successful build
Package: univention-appcenter
Version: 5.0.19-41.98.201601141021
Branch: ucs_4.1-0
Scope: errata4.1-0

Adapted yaml file r66781
Comment 16 Alexander Kläser univentionstaff 2016-01-20 15:51:42 CET
(In reply to Alexander Kramer from comment #13)
> (In reply to Dirk Wiesenthal from comment #11)
> > http://10.200.4.50/univention-management-console/#module=appcenter:appcenter:
> > 0:id:privacyidea shows a "undefined" title during StandBy while loading the
> > App. Is this bug responsible for that? Not a show stopper, but easy to fix?
> > set('title', val || 'App Center')?
> 
> r66483
> univention-appcenter (5.0.19-35) 
> * Bug #40116: Show 'App Center' instead of undefined inside module header

OK, looks good.

(In reply to Alexander Kramer from comment #15)
> r 66780
> univention-appcenter (5.0.19-41) 
> * Bug #40116: Don't show open button twice if isSingleServerInstallation

OK.

Would it make sense to display the "install" button in dark gray, i.e., as a default?

Otherwise everything seems to be fine.

→ VERIFIED
Comment 17 Janek Walkenhorst univentionstaff 2016-02-04 14:10:45 CET
<http://errata.software-univention.de/ucs/4.1/79.html>