Bug 40264 - App Center join lib: Use -it only when tty is a terminal
Summary: App Center join lib: Use -it only when tty is a terminal
Status: CLOSED FIXED
Alias: None
Product: UCS
Classification: Unclassified
Component: App Center
Version: UCS 4.1
Hardware: Other Linux
: P5 normal
Target Milestone: UCS 4.1-0-errata
Assignee: Dirk Wiesenthal
QA Contact: Florian Best
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-12-15 23:38 CET by Dirk Wiesenthal
Modified: 2016-02-04 14:10 CET (History)
2 users (show)

See Also:
What kind of report is it?: ---
What type of bug is this?: ---
Who will be affected by this bug?: ---
How will those affected feel about the bug?: ---
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional):
Customer ID:
Max CVSS v3 score:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dirk Wiesenthal univentionstaff 2015-12-15 23:38:35 CET 
The App Center joinscripthelper.sh provides
  joinscript_run_in_container

This calls docker exec -it "$CONTAINER" $@

This needs to be conditional as the UMC does not have stdin open as a terminal. Consequently, the command fails:
  time="2015-12-15T23:24:06+01:00" level=fatal msg="cannot enable tty mode on non tty input"
Comment 1 Dirk Wiesenthal univentionstaff 2015-12-15 23:39:11 CET 
Needed for an upcoming Docker App that makes use of this function
Comment 2 Dirk Wiesenthal univentionstaff 2015-12-16 00:31:45 CET 
Fixed in
  univention-appcenter 5.0.19-30.88.201512160029
Comment 3 Florian Best univentionstaff 2016-01-22 16:27:57 CET 
The functions now uses 'univention-app shell "$APP" $@'.
YAML: OK
Comment 4 Janek Walkenhorst univentionstaff 2016-02-04 14:10:08 CET 
<http://errata.software-univention.de/ucs/4.1/79.html>