Bug 41009 – Old App Center code evaluates installation status of Docker Apps incorrectly

Bug 41009 - Old App Center code evaluates installation status of Docker Apps incorrectly


Summary:	Old App Center code evaluates installation status of Docker Apps incorrectly

Status:	CLOSED FIXED

Product:	UCS
Classification:	Unclassified
Component:	App Center
Version:	UCS 4.1
Hardware:	Other Linux

Importance:	P1 normal (vote)
Target Milestone:	UCS 4.1-1-errata
Assigned To:	Dirk Wiesenthal
QA Contact:	Stefan Gohmann

URL:
Keywords:

Depends on:
Blocks:	41236
	Show dependency tree / graph

Reported:	2016-04-06 15:07 CEST by Dirk Wiesenthal
Modified:	2016-05-10 13:00 CEST (History)
CC List:	3 users (show)

See Also:
What kind of report is it?:	---
What type of bug is this?:	---
Who will be affected by this bug?:	---
How will those affected feel about the bug?:	---
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional):
Max CVSS v3 score:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Dirk Wiesenthal

2016-04-06 15:07:18 CEST

Old App Center code only goes over the DefaultPackages. This will always return True for Docker Apps like Jenkins and never for Docker Apps like OpenProject.

This is a problem in _set_ucr_codes_variable. When installing a Non-Docker App (via old code), at the end Jenkins will be marked as installed in
  repository/app_center/installed

Comment 1 Stefan Gohmann

2016-04-06 20:20:22 CEST

As discussed, please provide also an update for 4.1-0.

Comment 2 Dirk Wiesenthal

2016-04-08 12:23:10 CEST

I have added
  tests/80_docker/30_installed
for that.

Test passes since
  univention-appcenter 5.0.20-37.148.201604081220

"Copied" the is_installed method from new to old code.

Comment 3 Dirk Wiesenthal

2016-04-08 13:08:02 CEST

Repairing repository/app_center/installed in postinst in
  univention-appcenter 5.0.20-38.149.201604081305

Comment 4 Stefan Gohmann

2016-04-11 07:53:53 CEST

OK, it looks good and it works.

YAML: OK

Comment 5 Janek Walkenhorst

2016-04-13 14:57:50 CEST

<http://errata.software-univention.de/ucs/4.1/146.html>