Bug 41262 - Include univention-replicate-many into notifier package
Include univention-replicate-many into notifier package
Status: CLOSED FIXED
Product: UCS
Classification: Unclassified
Component: Notifier (univention-directory-notifier)
UCS 4.2
Other Linux
: P5 enhancement (vote)
: UCS 4.3-3-errata
Assigned To: Jannik Ahlers
Arvid Requate
:
: 41188 (view as bug list)
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2016-05-11 17:56 CEST by Ingo Sieverdingbeck
Modified: 2019-02-13 13:27 CET (History)
7 users (show)

See Also:
What kind of report is it?: Bug Report
What type of bug is this?: 2: Improvement: Would be a product improvement
Who will be affected by this bug?: 2: Will only affect a few installed domains
How will those affected feel about the bug?: 1: Nuisance – not a big deal but noticeable
User Pain: 0.023
Enterprise Customer affected?: Yes
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number: 2016042921000594
Bug group (optional):
Max CVSS v3 score:
steuwer: Patch_Available+


Attachments
PoC version of univention-replicate-many (3.65 KB, application/x-shellscript)
2016-05-11 17:56 CEST, Ingo Sieverdingbeck
Details
improved script (3.84 KB, text/plain)
2018-11-15 11:28 CET, Jannik Ahlers
Details
1.patch (448 bytes, patch)
2019-02-05 14:00 CET, Arvid Requate
Details | Diff
2.patch (2.42 KB, patch)
2019-02-05 14:04 CET, Arvid Requate
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ingo Sieverdingbeck univentionstaff 2016-05-11 17:56:52 CEST
Created attachment 7655 [details]
PoC version of univention-replicate-many

Please check the attached univention-replicate-many and include it in the notifier package. This script is based on univention-replicate-one and is intended to be used in case of multiple objects that have to be re-replicated.
Comment 1 Stefan Gohmann univentionstaff 2016-10-04 13:33:53 CEST
*** Bug 41188 has been marked as a duplicate of this bug. ***
Comment 2 Stefan Gohmann univentionstaff 2017-06-16 20:37:02 CEST
This issue has been filed against UCS 3. UCS 3 is out of the normal maintenance and many UCS components have vastly changed in UCS 4.

If this issue is still valid, please change the version to a newer UCS version otherwise this issue will be automatically closed in the next weeks.
Comment 3 Stefan Gohmann univentionstaff 2018-08-06 17:28:13 CEST
The script should consider empty lines, otherwise failed.ldifs will occur.
Comment 4 Jannik Ahlers univentionstaff 2018-11-15 11:28:37 CET
Created attachment 9745 [details]
improved script

I improved the script some. It now considers empty lines as well as invalid DNs. It will give info messages if invalid DNs occured.

I will come back to this in the next sprint.
Comment 5 Jannik Ahlers univentionstaff 2019-01-30 12:32:51 CET
I made some further adjustments and then included the script into the notifier package.

Successful build
Package: univention-directory-notifier
Version: 12.0.1-3A~4.3.0.201901301225
Branch: ucs_4.3-0
Scope: errata4.3-3

Successful build
Package: univention-directory-notifier
Version: 13.0.1-2A~4.4.0.201901301230
Branch: ucs_4.4-0
Scope:
Comment 6 Jannik Ahlers univentionstaff 2019-02-01 11:38:03 CET
I just noticed that I put the yaml in the wrong location...

univention-directory-notifier.yaml
78e0802c1997 | Bug #41262: move yaml to correct location
Comment 7 Arvid Requate univentionstaff 2019-02-05 12:21:50 CET
Did you actually try to install it? The script is now part of the Debian source package but it is not installed in the binary package.
Comment 8 Jannik Ahlers univentionstaff 2019-02-05 12:45:32 CET
I forgot to include the script in the debian/*.install file.

4.3-3:
d1b90c8 Bug #41262: yaml
cb014f6 Bug #41262: debian changelog
46547e0 Bug #41262: make sure univention-replicate-many gets installed into /sbin

Successful build
Package: univention-directory-notifier
Version: 12.0.1-5A~4.3.0.201902051238
Branch: ucs_4.3-0
Scope: errata4.3-3

4.4-0:
9217375 Bug #41262: debian changelog
4f9d1ff Bug #41262: make sure univention-replicate-many gets installed into /sbin

Successful build
Package: univention-directory-notifier
Version: 13.0.1-2A~4.4.0.201902051243
Branch: ucs_4.4-0
Scope:
Comment 9 Arvid Requate univentionstaff 2019-02-05 13:13:00 CET
UCS 4.4:

Commit 9217375b1f changed the changelog version to 13.0.1-3, but you have built:

Version: 13.0.1-2A~4.4.0.201902051243

That's why the script is not installed on my UCS 4.4.

Please acutally check the effectiveness of you changes before setting the bug to resolved.
Comment 10 Jannik Ahlers univentionstaff 2019-02-05 13:36:02 CET
Okay, this time it should be correct (yes I tried ;)
I Had to bump the version, otherwise the import failed.

commit 74548e1d7b9a90e75bc4e434d8815a9bcea4fc70
Bug #41262: version bump

Successful build
Package: univention-directory-notifier
Version: 13.0.1-4A~4.4.0.201902051325
Branch: ucs_4.4-0
Scope:
Comment 11 Arvid Requate univentionstaff 2019-02-05 14:00:31 CET
Created attachment 9827 [details]
1.patch

This patch fixes:

root@master10:~# univention-replicate-many
 is not readable
root@master10:~#
Comment 12 Arvid Requate univentionstaff 2019-02-05 14:04:26 CET
Created attachment 9828 [details]
2.patch

Additional coding style proposals. It doesn't make sense to use shellcheck and then disable https://github.com/koalaman/shellcheck/wiki/SC2206 .
Comment 13 Jannik Ahlers univentionstaff 2019-02-05 17:32:55 CET
I applied your patches.

4.3:
b77c2f7 Bug #41262: changelog
42947c2 Bug #41262: improve univention-replicate-many

Successful build
Package: univention-directory-notifier
Version: 12.0.1-7A~4.3.0.201902051728
Branch: ucs_4.3-0
Scope: errata4.3-3

4.4:
e7b1cc6 Bug #41262: changelog
7084e28 Bug #41262: improve univention-replicate-many

Successful build
Package: univention-directory-notifier
Version: 13.0.1-5A~4.4.0.201902051731
Branch: ucs_4.4-0
Scope:
Comment 14 Arvid Requate univentionstaff 2019-02-05 19:39:25 CET
Ok, it works.
Comment 15 Erik Damrose univentionstaff 2019-02-13 13:27:18 CET
<http://errata.software-univention.de/ucs/4.3/427.html>