Univention Bugzilla – Bug 41262
Include univention-replicate-many into notifier package
Last modified: 2019-02-13 13:27:18 CET
Created attachment 7655 [details] PoC version of univention-replicate-many Please check the attached univention-replicate-many and include it in the notifier package. This script is based on univention-replicate-one and is intended to be used in case of multiple objects that have to be re-replicated.
*** Bug 41188 has been marked as a duplicate of this bug. ***
This issue has been filed against UCS 3. UCS 3 is out of the normal maintenance and many UCS components have vastly changed in UCS 4. If this issue is still valid, please change the version to a newer UCS version otherwise this issue will be automatically closed in the next weeks.
The script should consider empty lines, otherwise failed.ldifs will occur.
Created attachment 9745 [details] improved script I improved the script some. It now considers empty lines as well as invalid DNs. It will give info messages if invalid DNs occured. I will come back to this in the next sprint.
I made some further adjustments and then included the script into the notifier package. Successful build Package: univention-directory-notifier Version: 12.0.1-3A~4.3.0.201901301225 Branch: ucs_4.3-0 Scope: errata4.3-3 Successful build Package: univention-directory-notifier Version: 13.0.1-2A~4.4.0.201901301230 Branch: ucs_4.4-0 Scope:
I just noticed that I put the yaml in the wrong location... univention-directory-notifier.yaml 78e0802c1997 | Bug #41262: move yaml to correct location
Did you actually try to install it? The script is now part of the Debian source package but it is not installed in the binary package.
I forgot to include the script in the debian/*.install file. 4.3-3: d1b90c8 Bug #41262: yaml cb014f6 Bug #41262: debian changelog 46547e0 Bug #41262: make sure univention-replicate-many gets installed into /sbin Successful build Package: univention-directory-notifier Version: 12.0.1-5A~4.3.0.201902051238 Branch: ucs_4.3-0 Scope: errata4.3-3 4.4-0: 9217375 Bug #41262: debian changelog 4f9d1ff Bug #41262: make sure univention-replicate-many gets installed into /sbin Successful build Package: univention-directory-notifier Version: 13.0.1-2A~4.4.0.201902051243 Branch: ucs_4.4-0 Scope:
UCS 4.4: Commit 9217375b1f changed the changelog version to 13.0.1-3, but you have built: Version: 13.0.1-2A~4.4.0.201902051243 That's why the script is not installed on my UCS 4.4. Please acutally check the effectiveness of you changes before setting the bug to resolved.
Okay, this time it should be correct (yes I tried ;) I Had to bump the version, otherwise the import failed. commit 74548e1d7b9a90e75bc4e434d8815a9bcea4fc70 Bug #41262: version bump Successful build Package: univention-directory-notifier Version: 13.0.1-4A~4.4.0.201902051325 Branch: ucs_4.4-0 Scope:
Created attachment 9827 [details] 1.patch This patch fixes: root@master10:~# univention-replicate-many is not readable root@master10:~#
Created attachment 9828 [details] 2.patch Additional coding style proposals. It doesn't make sense to use shellcheck and then disable https://github.com/koalaman/shellcheck/wiki/SC2206 .
I applied your patches. 4.3: b77c2f7 Bug #41262: changelog 42947c2 Bug #41262: improve univention-replicate-many Successful build Package: univention-directory-notifier Version: 12.0.1-7A~4.3.0.201902051728 Branch: ucs_4.3-0 Scope: errata4.3-3 4.4: e7b1cc6 Bug #41262: changelog 7084e28 Bug #41262: improve univention-replicate-many Successful build Package: univention-directory-notifier Version: 13.0.1-5A~4.4.0.201902051731 Branch: ucs_4.4-0 Scope:
Ok, it works.
<http://errata.software-univention.de/ucs/4.3/427.html>