Univention Bugzilla – Bug 43155
ucs-school-join-secondary-samba4 failed
Last modified: 2023-06-12 15:39:58 CEST
The Jenkins setup NoImportTests,s4-with-slave failed: Execute: /root/ucs-school-join-secondary-samba4 --dcaccount Administrator --dcpwd /tmp/univention --rootpassword /tmp/univention 10.210.108.237 [...] Traceback (most recent call last): File "/usr/sbin/univention-add-app", line 152, in <module> requested_app.unregister_all_and_register(previously_registered) TypeError: unregister_all_and_register() takes at least 4 arguments (2 given) *** Failed 1: /root/ucs-school-join-secondary-samba4 --dcaccount Administrator --dcpwd /tmp/univention --rootpassword /tmp/univention 10.210.108.237 http://jenkins.knut.univention.de:8080/job/UCSschool%204.1/job/UCSschool%204.1%20(R2)%20Singleserver/ImportTests=NoImportTests,SambaVersion=s4-with-slave/321/
According to the manual: "Auf diesem sekundären Domänencontroller wird nicht die UCS@school App installiert." Since UCS 4.1 libunivention-ldb-modules is part of UCS (instead of UCS@school), therefore it should be sufficient to replace univention-add-app ucsschool -l libunivention-ldb-modules || exit 1 with univention-install -y libunivention-ldb-modules || exit 1
But yes, univention-add-app is broken when doing the legacy call. univention-add-app ucsschool -l libunivention-ldb-modules -> univention-add-app ucsschool -l && univention-install libunivention-ldb-modules univention-add-app itself is soon to become a legacy call, too, though.
(In reply to Dirk Wiesenthal from comment #2) > univention-add-app ucsschool -l Does "univention-add-app ucsschool -l" install the default packages of the specified app?
No, it just adds the repository
Created attachment 8321 [details] workaround workaround
Running ucs-school-join-secondary-samba4 against a ucs-school-singlemaster is expected to lead to undefined behavior. See bug 43311 Comment 1.
The secondary slave setup fails also in"normal" setup UCS Master + school (without samba) School Slave Secondary School Slave The documentation states "Auf diesem sekundären Domänencontroller wird nicht die UCS@school App installiert." so i did not install school on my second slave. But the univention-samba4 join script checks exit_on_slave_if_no_s4_connector_on_master_or_backup and if don't have s4 on my master. The Join scripts aborts and the installation of my second slave fails. exit_on_slave_if_no_s4_connector_on_master_or_backup actually ignores ucs@school slaves (return if samba4/provision/secondary is true). But samba4/provision/secondary is only set in the school meta packages and as described in the documentation i did not install school. So there is more work to do here.
Now i also tested the secondary school slave with samba in the central department. And now univention-samba4 join script fails here too File: /etc/samba/base.conf Multifile: /etc/samba/smb.conf ERROR: We are joining to an UCS@school domain but shell-ucs-school is not installed ERROR: Make sure that UCS@school metapackages are installed properly So ucs-school-join-secondary-samba4 does not work at the moment.
(In reply to Felix Botner from comment #8) > Now i also tested the secondary school slave with samba in the central > department. > > And now univention-samba4 join script fails here too > > File: /etc/samba/base.conf > Multifile: /etc/samba/smb.conf > ERROR: We are joining to an UCS@school domain but shell-ucs-school is not > installed > ERROR: Make sure that UCS@school metapackages are installed properly > > So ucs-school-join-secondary-samba4 does not work at the moment. we should either drop ucs-school-join-secondary-samba4 or we should integrate it in univention-samba4/s4connector In the univention-samba4 join script we already have helper to determine if we are in an ucs@school domain, a helper to get the school OU (empty if the server is in the central department) and helper to get the existing s4 connector dc. With that we can easily figure out if we are the first school slave, the second school slave or if this is a slave in the central department and do the necessary steps.
Deferred until the new samba installation concept is implemented.
This issue has been filed against UCS@school 4.1. We have discontinued support for this scenario since UCS@school 4.4. Furthermore UCS@school 4.1 is out of maintenance and many UCS@school components have changed in later releases. Thus, this issue is now being closed. If this issue still occurs in newer UCS@school versions, please reopen it and update the UCS@school version. In this case please provide detailed information on how this issue is affecting you.