Bug 43235 – [S4Connector] Traceback when reading pickle files

Bug 43235 - [S4Connector] Traceback when reading pickle files


Summary:	[S4Connector] Traceback when reading pickle files

Status:	CLOSED FIXED

Product:	UCS
Classification:	Unclassified
Component:	S4 Connector
Version:	UCS 4.1
Hardware:	Other Linux

Importance:	P5 normal (vote)
Target Milestone:	UCS 4.1-4-errata
Assigned To:	Florian Best
QA Contact:	Stefan Gohmann

URL:
Keywords:

Duplicates:	27332 (view as bug list)
Depends on:	42507
Blocks:
	Show dependency tree / graph

Reported:	2016-12-21 09:08 CET by Florian Best
Modified:	2017-01-05 11:22 CET (History)
CC List:	1 user (show)

See Also:
What kind of report is it?:	Bug Report
What type of bug is this?:	5: Major Usability: Impairs usability in key scenarios
Who will be affected by this bug?:	2: Will only affect a few installed domains
How will those affected feel about the bug?:	5: Blocking further progress on the daily work
User Pain:	0.286
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional):
Max CVSS v3 score:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Florian Best

2016-12-21 09:08:36 CET

Merge the fix to S4-Connector.

+++ This bug was initially created as a clone of Bug #42507 +++

Bei einem begleiteten Benutzerimport fiel folgender Traceback im 'connector-status.log' auf.


 --- connect failed, failure was: ---

Traceback (most recent call last):
  File "/usr/share/pyshared/univention/connector/ad/main.py", line 290, in main
    connect()
  File "/usr/share/pyshared/univention/connector/ad/main.py", line 234, in connect
    change_counter=ad.poll_ucs()
  File "/usr/lib/pymodules/python2.7/univention/connector/__init__.py", line 911, in poll_ucs
    self._generate_dn_list_from(files)
  File "/usr/lib/pymodules/python2.7/univention/connector/__init__.py", line 885, in _generate_dn_list_from
    dn,new,old,old_dn=cPickle.load(f)
ValueError: insecure string pickle


folgende Pakete sind installiert:
 python-univention-connector      10.0.2-9.509.201609131411
 python-univention-connector-ad   10.0.2-9.509.201609131411
 univention-ad-connector          10.0.2-9.509.201609131411

Comment 1 Florian Best

2016-12-22 12:27:37 CET

*** Bug 27332 has been marked as a duplicate of this bug. ***

Comment 2 Florian Best

2016-12-22 12:48:38 CET

univention-s4-connector (10.0.4-5):
r75506 | Bug #43235: debian changelog version number
r75503 | Bug #43235: code cleanup
r75502 | Bug #43235: Fix race condition between writing and reading pickle files

univention-s4-connector.yaml:
r75507 | YAML Bug #43235

UCS 4.2 Merge:
univention-s4-connector (11.0.3-5):
r75505 | Bug #43235: code cleanup
r75504 | Bug #43235: Fix race condition between writing and reading pickle files

I added an additional cleanup commit:

The code introduced in svn r37846, Bug #29625, UCS 3.1 is obviously
wrong and broken since it was commited. The variable "ud" was never
defined so if the impossible-dead-code-block would be reached it would
cause the s4 connector to crash immediately. (Also the whole code block didn't make sense as if it would there would be a serious problem/bug in cPickle.)

svn cat -r 37846 svn+ssh://billy.knut.univention.de/var/univention/svn/dev/branches/ucs-3.1/ucs-3.1-1/services/univention-s4-connector/s4-connector.py | vim -

Comment 3 Stefan Gohmann

2017-01-04 15:33:51 CET

Tests: OK

UCS Test: OK

Code review: OK

YAML: OK

UCS 4.2 merge: OK

Comment 4 Janek Walkenhorst

2017-01-05 11:22:43 CET

<http://errata.software-univention.de/ucs/4.1/369.html>