Bug 43385 - Installation succeeds with error messages if something was written to stderr
Installation succeeds with error messages if something was written to stderr
Status: CLOSED FIXED
Product: UCS
Classification: Unclassified
Component: App Center
UCS 4.1
Other Linux
: P5 normal (vote)
: UCS 4.1-4-errata
Assigned To: Dirk Wiesenthal
Felix Botner
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2017-01-20 16:05 CET by Dirk Wiesenthal
Modified: 2017-02-22 12:33 CET (History)
1 user (show)

See Also:
What kind of report is it?: Bug Report
What type of bug is this?: 5: Major Usability: Impairs usability in key scenarios
Who will be affected by this bug?: 1: Will affect a very few installed domains
How will those affected feel about the bug?: 2: A Pain – users won’t like this once they notice it
User Pain: 0.057
Enterprise Customer affected?:
School Customer affected?:
ISV affected?: Yes
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional):
Max CVSS v3 score:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Dirk Wiesenthal univentionstaff 2017-01-20 16:05:38 CET
When some scripts write to stderr, this is shown as an error in UMC when installing an App.

Sometimes the script does not fail, the stderr message was just a simple warning but everything was fine.

This is highly confusing. We should only show errors when the installation actually failed.
Comment 1 Dirk Wiesenthal univentionstaff 2017-02-06 09:57:56 CET
We should also lower the log level in some cases, specifically when an ini file is not readable.
Comment 2 Felix Botner univentionstaff 2017-02-09 09:23:13 CET
Ok, as discussed, i give this to you:

Just changing the "log level" in the java code (remove res.level == 'WARNING' in AppDetailsPage.js@callInstaller) removes the stdout messages, but also in case of an actual failure.

What we want is, no message on success=true, "all" message on success=false.
Comment 3 Felix Botner univentionstaff 2017-02-10 09:55:17 CET
I have added some more test in 40_app_umc_install_latest_appbox (check installation if setup script writes to stderr but returns 0, check installation if setup script writes to stderr and returns 1).

Please update install_via_umc in tests/80_docker/dockertest.py according to the fix here. Currently install_via_umc treats 'WARNING', 'ERROR', 'CRITICAL as errors.
Comment 4 Dirk Wiesenthal univentionstaff 2017-02-18 03:28:11 CET
Fixed in
  univention-appcenter 5.0.23-59.283.201702180315

by only using ERROR, CRITICAL, not WARNING.
This means, to show an error, you have to do MODULE.error in UMC or self.fatal() or raise Abort() - self.warn() will not longer show up. I have raised and lowered some error messages.

Also put that into
  ucs-test 6.0.37-53.1595.201702180320
Comment 5 Felix Botner univentionstaff 2017-02-20 13:35:47 CET
OK - only critical errors are show
OK - merged to 4.2-0
OK - test
OK - yaml
Comment 6 Janek Walkenhorst univentionstaff 2017-02-22 12:33:01 CET
<http://errata.software-univention.de/ucs/4.1/403.html>