Bug 43423 - Fix asterisk modules
Fix asterisk modules
Status: CLOSED FIXED
Product: UCS
Classification: Unclassified
Component: UDM (Generic)
UCS 4.1
Other Linux
: P5 normal (vote)
: UCS 4.1-4-errata
Assigned To: Florian Best
Stefan Gohmann
:
Depends on: 43048
Blocks:
  Show dependency treegraph
 
Reported: 2017-01-25 17:07 CET by Florian Best
Modified: 2019-08-29 12:24 CEST (History)
1 user (show)

See Also:
What kind of report is it?: Bug Report
What type of bug is this?: 7: Crash: Bug causes crash or data loss
Who will be affected by this bug?: 2: Will only affect a few installed domains
How will those affected feel about the bug?: 5: Blocking further progress on the daily work
User Pain: 0.400
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional): Regression
Max CVSS v3 score:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Florian Best univentionstaff 2017-01-25 17:07:43 CET
We introduced a regression with UCS 4.1-3 Errata 319 and 312.

http://errata.software-univention.de/ucs/4.1/319.html
http://errata.software-univention.de/ucs/4.1/321.html

The asterisk UDM modules aren't shown in a tree view anymore in UMC and therefore there are some exceptions complaining about missing superordinates. This makes all asterisk handlers unusable.
Comment 1 Florian Best univentionstaff 2017-01-25 17:23:46 CET
univention-management-console-module-udm (6.0.11-36):
r76100 | Bug #43423: treat asterisk/asterisk as superordinate module with a tree

univention-directory-manager-modules (11.0.3-56):
r76099 | Bug #43423: find superordinate automatically if not given

Merge to UCS 4.2:
univention-management-console-module-udm (7.0.3-3):
r76105 | Bug #43423: debian/changelog
r76103 | Bug #43423: treat asterisk/asterisk as superordinate module with a tree

univention-directory-manager-modules (12.0.12-3):
r76105 | Bug #43423: debian/changelog
r76102 | Bug #43423: find superordinate automatically if not given
Comment 2 Florian Best univentionstaff 2017-01-25 17:30:41 CET
univention-management-console-module-udm.yaml:
r76106 | YAML Bug #43423 Bug #43048

univention-directory-manager-modules.yaml:
r76106 | YAML Bug #43423 Bug #43048
Comment 3 Florian Best univentionstaff 2017-01-26 14:01:39 CET
Added two more commits:

univention-management-console-module-udm (6.0.11-37):
r76125 | Bug #43423: set tree root operations to search-only except for navigation
→ disallow to edit the ldap/base in the asterisk module.

univention-directory-manager-modules (11.0.3-57):
r76126 | Bug #43423: defer validations to the bottom of __init__, readd settings/cn workaround
→ I thought this fixed settings/cn but actually doesn't because of Bug #43427
→ the checks are also done at the end of __init__ so that subclassing have more powerful abilities
Comment 4 Stefan Gohmann univentionstaff 2017-02-13 07:58:46 CET
If I create a new telephone entry in the Asterisk4UCS Management, it is not created below the Asterisk server object. If I select the Asterisk server object and try to create a new telephone object, I get an empty page.

It seems to be a different between 4.0-4 and 4.1-4-errata.

My test systems:
- 4.1-4 with latest test errata: 10.201.41.1
- 4.0: 10.201.71.1
Comment 5 Florian Best univentionstaff 2017-02-13 11:56:24 CET
Please test with Asterisk4UCS 1.0.10 from http://appcenter-test.software-univention.de/meta-inf/4.1/asterisk4ucs/asterisk4ucs_20170202103033.ini.
Comment 6 Stefan Gohmann univentionstaff 2017-02-14 06:58:52 CET
(In reply to Florian Best from comment #5)
> Please test with Asterisk4UCS 1.0.10 from
> http://appcenter-test.software-univention.de/meta-inf/4.1/asterisk4ucs/
> asterisk4ucs_20170202103033.ini.

OK, it looks better. The asteriskUser module does not work:

http://10.201.41.1/univention-management-console/?lang=de-DE#module=asteriskUser::0:

I don't know if it is the scope of this bug. If not, please set the bug to fixed again.
Comment 7 Florian Best univentionstaff 2017-02-14 11:22:22 CET
(In reply to Stefan Gohmann from comment #6)
> (In reply to Florian Best from comment #5)
> > Please test with Asterisk4UCS 1.0.10 from
> > http://appcenter-test.software-univention.de/meta-inf/4.1/asterisk4ucs/
> > asterisk4ucs_20170202103033.ini.
> 
> OK, it looks better. The asteriskUser module does not work:
> 
> http://10.201.41.1/univention-management-console/?lang=de-
> DE#module=asteriskUser::0:
> 
> I don't know if it is the scope of this bug. If not, please set the bug to
> fixed again.

Not scope of this bug, it's their business! Nevertheless I fixed it via https://github.com/decoit/asterisk4ucs/pull/18

The other issues I fixed related to this bug are:
https://github.com/decoit/asterisk4ucs/pull/4
https://github.com/decoit/asterisk4ucs/pull/6
https://github.com/decoit/asterisk4ucs/pull/7
https://github.com/decoit/asterisk4ucs/pull/8
https://github.com/decoit/asterisk4ucs/pull/9
https://github.com/decoit/asterisk4ucs/pull/10
https://github.com/decoit/asterisk4ucs/pull/13
https://github.com/decoit/asterisk4ucs/pull/14
https://github.com/decoit/asterisk4ucs/pull/16
Comment 8 Stefan Gohmann univentionstaff 2017-02-14 14:43:55 CET
(In reply to Florian Best from comment #7)
> Not scope of this bug, it's their business! Nevertheless I fixed it via
> https://github.com/decoit/asterisk4ucs/pull/18

OK