Bug 44450 – SAML login raises AttributeError: 'NoneType' object has no attribute 'get'

Bug 44450 - SAML login raises AttributeError: 'NoneType' object has no attribute 'get'


Summary:	SAML login raises AttributeError: 'NoneType' object has no attribute 'get'

Status:	CLOSED FIXED

Product:	UCS
Classification:	Unclassified
Component:	UMC (Generic)
Version:	UCS 4.2
Hardware:	Other Linux

Importance:	P5 normal (vote)
Target Milestone:	UCS 4.2-0-errata
Assigned To:	Florian Best
QA Contact:	Richard Ulmer

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2017-04-21 17:11 CEST by Florian Best
Modified:	2018-01-15 16:32 CET (History)
CC List:	1 user (show)

See Also:
What kind of report is it?:	Bug Report
What type of bug is this?:	5: Major Usability: Impairs usability in key scenarios
Who will be affected by this bug?:	3: Will affect average number of installed domains
How will those affected feel about the bug?:	3: A User would likely not purchase the product
User Pain:	0.257
Enterprise Customer affected?:	Yes
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:	2017122921000424, 2017041821000808, 2017042421000574, 2017042721001291, 2017050521000438, 2017050521000536, 2017060721000807
Bug group (optional):	External feedback
Max CVSS v3 score:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Florian Best

2017-04-21 17:11:57 CEST

Version: 4.2-0 errata1 (Lesum)

The server encountered an unexpected condition which prevented it from fulfilling the request.

Traceback (most recent call last):
  File "/usr/lib/python2.7/dist-packages/cherrypy/_cprequest.py", line 670, in respond
    response.body = self.handler()
  File "/usr/lib/python2.7/dist-packages/cherrypy/lib/encoding.py", line 217, in __call__
    self.body = self.oldhandler(*args, **kwargs)
  File "/usr/lib/python2.7/dist-packages/cherrypy/_cpdispatch.py", line 61, in __call__
    return self.callable(*self.args, **self.kwargs)
  File "/usr/sbin/univention-management-console-web-server", line 981, in sso
    cherrypy.response.headers['Location'] = user.data.get('relay_state', {}).get('referer') or '/univention/management/'
AttributeError: 'NoneType' object has no attribute 'get'

Comment 1 Florian Best

2017-04-27 12:28:20 CEST

Reported again, 4.2-0 errata0 (Lesum) - UCS@school 4.2 v1

Comment 2 Florian Best

2017-04-28 07:34:11 CEST

Reported again, 4.2-0 errata4 (Lesum)

Comment 3 Florian Best

2017-05-02 16:44:15 CEST

univention-management-console.yaml:
r79015 | YAML Bug #44217 Bug #44450 Bug #43859

univention-management-console (9.0.80-5):
r79013 | Bug #44450: Bug #44217: fix errors during SAML login

Comment 4 Florian Best

2017-05-05 15:41:33 CEST

Version: 4.2-0 errata4 (Lesum)

Remark: Fehlermeldung kam nach Anmeldung als Administrator nach einem reboot des Server als dieser den Fehler:

SimpleSAML_Error_BadRequest: BADREQUEST('%REASON%' => 'Missing AuthState parameter.')

ausgab

Comment 6 Florian Best

2017-05-10 16:03:11 CEST

Reported again, 4.2-0 errata4 (Lesum)

Remark: Fehler wird alle paar Stunden wiederholt. Kein Internetzugang

Comment 7 Florian Best

2017-05-16 12:26:20 CEST

To reproduce this error you need to open the login page (ucs-sso.…) and restart the UMC-Webserver before submitting the credentials form.

Comment 8 Richard Ulmer

2017-05-16 13:35:40 CEST

I was able to reproduce the bug using Comment #7, but still got the same traceback posted in Comment #1 after updating univention-management-console.

Comment 9 Florian Best

2017-05-16 13:40:28 CEST

univention-management-console (9.0.80-12):
r79367 | Bug #44450: fix exception during SAML login

Comment 10 Richard Ulmer

2017-05-16 14:18:18 CEST

Ok, looks good now. -> Verified

Comment 11 Janek Walkenhorst

2017-06-15 17:58:10 CEST

<http://errata.software-univention.de/ucs/4.2/40.html>

Comment 12 Johannes Keiser

2018-01-15 16:32:31 CET

Reported again: Version: 4.2-0 errata0 (Lesum)

Remark: nach Upgrade von 4.1.5 auf 4.2.0 tauchte dieser Fehler auf