Bug 45068 – Remove unnecessary superordinate detection in S4 Connector

Bug 45068 - Remove unnecessary superordinate detection in S4 Connector


Summary:	Remove unnecessary superordinate detection in S4 Connector

Status:	CLOSED FIXED

Product:	UCS
Classification:	Unclassified
Component:	S4 Connector
Version:	UCS 4.2
Hardware:	Other Linux

Importance:	P5 normal (vote)
Target Milestone:	UCS 4.4-0-errata
Assigned To:	Florian Best
QA Contact:	Arvid Requate

URL:
Keywords:

Depends on:
Blocks:	49355
	Show dependency tree / graph

Reported:	2017-07-25 14:59 CEST by Florian Best
Modified:	2019-04-29 21:16 CEST (History)
CC List:	0 users

See Also:	49086
What kind of report is it?:	Development Internal
What type of bug is this?:	---
Who will be affected by this bug?:	---
How will those affected feel about the bug?:	---
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional):
Max CVSS v3 score:

Attachments
patch (12.20 KB, patch) 2017-07-25 14:59 CEST, Florian Best	Details \| Diff
patch (17.81 KB, patch) 2019-04-07 20:00 CEST, Florian Best	Details \| Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Florian Best

2017-07-25 14:59:15 CEST

Created attachment 9053 [details]
patch

Since Bug #34764 superordinates are automatically detected if not given as argument to object() or objects.get(). They use the DN or the position-DN to determine the superordinate. Attached is a patch which removes unnecessary code.

Comment 1 Florian Best

2019-04-07 20:00:19 CEST

Created attachment 9959 [details]
patch

Rebased patch (branch fbest/45068-remove-explicit-superordinate).
All (215) S4 Connector tests passed:
http://jenkins.knut.univention.de:8080/job/UCS-4.4/job/UCS-4.4-0/view/Branch%20Tests/job/branch%20test%20samba%20s4-connector/11/testReport/

Comment 2 Florian Best

2019-04-11 10:34:48 CEST

Patch applied.

univention-s4-connector (13.0.2-5)
f3ff224a0e1f | Bug #45068: Remove unnecessary explicit superordinate search in S4 Connector

univention-s4-connector.yaml
2589737436ad | YAML Bug #45068

Comment 3 Arvid Requate

2019-04-11 15:18:52 CEST

* Code review: Ok
* ucs-test s4connector: Ok
* Advisory: Ok

Comment 4 Arvid Requate

2019-04-24 13:12:57 CEST

<http://errata.software-univention.de/ucs/4.4/58.html>