Bug 45146 - Adjust uses of notifications to new implementation
Adjust uses of notifications to new implementation
Status: RESOLVED WONTFIX
Product: UCS
Classification: Unclassified
Component: UMC (Generic)
UCS 4.2
Other Linux
: P5 normal (vote)
: ---
Assigned To: UMC maintainers
UMC maintainers
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2017-08-07 15:49 CEST by Johannes Keiser
Modified: 2020-07-03 20:52 CEST (History)
0 users

See Also:
What kind of report is it?: Development Internal
What type of bug is this?: ---
Who will be affected by this bug?: ---
How will those affected feel about the bug?: ---
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional): Cleanup
Max CVSS v3 score:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Johannes Keiser univentionstaff 2017-08-07 15:49:53 CEST
Bug #43658 introduced two types of notifications: global notifications and
context based notifications. (see https://forge.univention.org/bugzilla/show_bug.cgi?id=43658#c5 for more information)

Some uses of notifications should be changed to fit the new implementation:

#### Use context notification instead of global notification:

[ ~/svn/ucs-4.2/ucs-4.2-1/management/univention-management-console-module-udm/umc/js/udm/DetailPage.js ]
  _showUsernameTooLongWarning: function(changedValues) {
    dialog.warn(lang.repla...

[ ~/svn/ucs-4.2/ucs-4.2-1/services/univention-ad-connector/umc/js/adconnector/SetupWizard.js ]
  dialog.notify(_('The certificate was imported successfully'));

[ ~/svn/ucs-4.2/ucs-4.2-1/virtualization/univention-virtual-machine-manager-daemon/umc/js/uvmm/DomainPage.js ]
  addNotification: dialog.notify,
[ ~/svn/ucs-4.2/ucs-4.2-1/virtualization/univention-virtual-machine-manager-daemon/umc/js/uvmm/TreeModel.js ]
  dialog.notify(_('The UVMM service is currently not available. Please trigger a search to refresh the view.'));

[ ~/svn/ucs-4.2/ucs-4.2-1/virtualization/univention-virtual-machine-manager-daemon/umc/js/uvmm/InstancePage.js ]
  addNotification: dialog.notify,

[ ~/svn/ucs-4.2/ucs-4.2-1/virtualization/univention-virtual-machine-manager-daemon/umc/js/uvmm/DomainPage.js ]
  addNotification: dialog.notify,

#### Change from context notification to context warning (since the text is so long):

[ ~/svn/ucs-4.2/ucs-4.2-1/virtualization/univention-virtual-machine-manager-daemon/umc/js/uvmm/DomainPage.js ]
  this.addNotification( _( '<p>For fail over the virtual machine can be migrated to another physical server re-using the last known configuration and all disk ...

#### Add a title to global notifications

[ ~/svn/ucs-4.2/ucs-4.2-1/base/univention-updater/umc/js/updater.js ]
  dialog.notify(_('An update for UCS is available. Please visit the %s to install the updates.', link))

[ ~/svn/ucs-4.2/ucs-4.2-1/management/univention-join/umc/js/join.js ]
  dialog.notify(_('Not all installed components have been registered. Please visit the %s to register the remaining components.', joinModuleLink));


  dialog.notify(_('As %(root)s you do not have access to the App Center. For this you need to log in as %(administrator)s.', {root: '<strong>root</strong>', administrator: login_as_admin_tag}));

  dialog.notify(_('As %(root)s you have neither access to the domain administration nor to the App Center. For this you need to log in as %(administrator)s.', {root: '<strong>root</strong>', administrator: login_as_admin_tag}));

[ ~/svn/ucs-4.2/ucs-4.2-1/management/univention-management-console-module-reboot/umc/js/reboot.js ]
  dialog.notify(_('This system has been updated recently. Please reboot this system to finish the update.'));

#### Remove double use 'Warning'
[ ~/svn/ucs-4.2/ucs-4.2-1/base/univention-updater/umc/js/updater.js ]
 var warning = _("<b style='color: #ff7070'>Warning:</b> The currently used UCS version is out of maintenance. Plase visit the %s for more information", link);
 dialog.warn(warning);
Comment 1 Ingo Steuwer univentionstaff 2020-07-03 20:52:18 CEST
This issue has been filed against UCS 4.2.

UCS 4.2 is out of maintenance and many UCS components have changed in later releases. Thus, this issue is now being closed.

If this issue still occurs in newer UCS versions, please use "Clone this bug" or reopen it and update the UCS version. In this case please provide detailed information on how this issue is affecting you.