Bug 46197 - UMC "System diagnostic" non-critical samba-tool dbcheck messages are shown as critical
UMC "System diagnostic" non-critical samba-tool dbcheck messages are shown as...
Status: CLOSED FIXED
Product: UCS
Classification: Unclassified
Component: UMC - System diagnostic
UCS 4.2
Other Linux
: P5 minor (vote)
: UCS 4.3-1-errata
Assigned To: Arvid Requate
Felix Botner
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2018-01-30 17:54 CET by Arvid Requate
Modified: 2018-07-25 13:56 CEST (History)
2 users (show)

See Also:
What kind of report is it?: Bug Report
What type of bug is this?: 2: Improvement: Would be a product improvement
Who will be affected by this bug?: 4: Will affect most installed domains
How will those affected feel about the bug?: 2: A Pain – users won’t like this once they notice it
User Pain: 0.091
Enterprise Customer affected?: Yes
School Customer affected?: Yes
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number: 2018013021000422, 2018040621000285
Bug group (optional):
Max CVSS v3 score:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Arvid Requate univentionstaff 2018-01-30 17:54:36 CET
Currently the system diagnostic samba-tool dbcheck output is shown as "critical" if samba-tool returns a non-zero exit status.

Some reported issues appear frequently e.g. when user objects are removed but the "member" attribute in some groups still points to the target GUID of the deleted object. The appearence and detection of these errors varies with the Samba package version. Some appear to be more cosmetic inconsistencies and should not be displayed as critical.
Comment 1 Stefan Gohmann univentionstaff 2018-01-31 07:56:21 CET
Wouldn't it be better to check why it happens? I don't think it should be the normal state that the database is inconsistent.
Comment 2 Arvid Requate univentionstaff 2018-01-31 10:13:05 CET
Yes, I agree, we should check UCS 4.1 and UCS 4.2 Samba versions to reproduce the reported error. samba-tool dbcheck seems to diffreenciate between "NOTE" and "ERROR". E.g. here's a note which apparently doesn't cause a non-zero exit status:

==========================================================================
root@master10:~# samba-tool dbcheck
Checking 1241 objects
NOTE: old (due to rename or delete) DN string component for lastKnownParent in object cn=subcontainer1\0ADEL:214c2994-e5c4-45f2-83fb-5343af367d8c,CN=Deleted Objects,DC=ar41i1,DC=qa - <GUID=18b95df7-833d-4be2-96b1-dc399f6312de>;CN=container1,CN=Groups,DC=ar41i1,DC=qa
Not fixing old string component
Checked 1241 objects (0 errors)
==========================================================================

In contrast the error message reported in the ticket (screenshot) shows something like this:
==========================================================================
ERROR: target DN is deleted for member in object CN=somegroup,CN=groups,DC=mydomain,DC=intranet
Target GUID points at deleted DN cn=member1\0ADEL:12345678-1234-1234-1234-12345678890a,CN=Deleted Objects,DC=mydomain,DC=intranet
Not removing
Checked 1234 objects (1 errors)
==========================================================================

From my experience I vaguely recall this to happen when a user gets deleted that is member of additional groups. The ticket currently doesn't state the affected UCS release, I'll ask for this informaton.
Comment 3 Stefan Gohmann univentionstaff 2018-01-31 10:31:34 CET
OK, I understand. That it should be easy to ignore the NOTE messages and only show the ERROR messages.
Comment 4 Christina Scheinig univentionstaff 2018-05-07 15:08:25 CEST
The UCS Version in Ticket 2018040621000285 is 4.3
Comment 5 Fathan Vidjaja univentionstaff 2018-07-17 13:24:38 CEST
UMC diagnosis tool should only show errors now. warnings will not be shown in UMC.
If samba-tool dbcheck has no errors(only warnings or nothing), the dbcheck in UMC diagnosis tool won't show an error.
Comment 6 Arvid Requate univentionstaff 2018-07-24 17:38:30 CEST
37d7a0736c | Fathans initial commit
96d5e69979 | Only show samba-tool dbcheck errors as critical
a50dc65edd | Advisory
Comment 7 Felix Botner univentionstaff 2018-07-25 10:28:41 CEST
OK - univention-management-console-module-diagnostic (only critical if ERROR in 
     output of samba-tool dbcheck)
OK - yaml
Comment 8 Arvid Requate univentionstaff 2018-07-25 13:56:33 CEST
<http://errata.software-univention.de/ucs/4.3/153.html>