Bug 47603 – failed.ldif not purged on rejoin

Bug 47603 - failed.ldif not purged on rejoin


Summary:	failed.ldif not purged on rejoin

Status:	CLOSED FIXED

Product:	UCS
Classification:	Unclassified
Component:	Join (univention-join)
Version:	UCS 4.2
Hardware:	Other Linux

Importance:	P5 normal (vote)
Target Milestone:	UCS 4.4-0-errata
Assigned To:	Julia Bremer
QA Contact:	Arvid Requate

URL:
Keywords:

Depends on:
Blocks:	47598
	Show dependency tree / graph

Reported:	2018-08-17 11:48 CEST by Philipp Hahn
Modified:	2019-04-24 13:13 CEST (History)
CC List:	3 users (show)

See Also:
What kind of report is it?:	Bug Report
What type of bug is this?:	6: Setup Problem: Issue for the setup process
Who will be affected by this bug?:	2: Will only affect a few installed domains
How will those affected feel about the bug?:	3: A User would likely not purchase the product
User Pain:	0.206
Enterprise Customer affected?:	Yes
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:	2018080921000496, 2019022021000232
Bug group (optional):
Max CVSS v3 score:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Philipp Hahn

2018-08-17 11:48:04 CEST

After a failed join a customer had to re-execute univention-join.
The scripts checks for /var/lib/univention-directory-replication/failed.ldif only in line 214, but the OpenLDAP slapd is already started in line 546: /etc/init.d/slapd then finds the failed.ldif file an tries to apply it!

Similar to Bug #41782 comment 19 the failed.ldif file should be detected early on and either be deleted or the script should abort.

Comment 1 Christina Scheinig

2019-02-20 12:24:34 CET

Happened again. The failed.ldif still exists during rejoin, and causes the join to fail after hours.

Comment 2 Julia Bremer

2019-04-16 17:47:00 CEST

a0547eeb02 Bug #47603: YAML
a53a6e5939 Bug #47603: Remove failed.ldif early if exists

Successful build
Package: univention-join
Version: 11.0.1-16A~4.4.0.201904161731
Branch: ucs_4.4-0
Scope: errata4.4-0
User: jbremer
Host: dimma.knut.univention.de
Logfile Path: /var/univention/buildsystem2/logs/ucs_4.4-0-0-errata4.4-0/univention-join_11.0.1-16A~4.4.0.201904161731.log.bz2

the failed.ldif will now be removed at the beginning of a join if it exists.

Comment 3 Arvid Requate

2019-04-23 19:05:08 CEST

Verified:
* Code review
* Functional test
* Advisory

Comment 4 Arvid Requate

2019-04-24 13:13:02 CEST

<http://errata.software-univention.de/ucs/4.4/56.html>