Bug 47857 - Traceback in UMC notifier exception handling
Traceback in UMC notifier exception handling
Status: CLOSED FIXED
Product: UCS
Classification: Unclassified
Component: UMC (Generic)
UCS 4.3
Other Linux
: P5 normal (vote)
: UCS 4.3-2-errata
Assigned To: Philipp Hahn
Jürn Brodersen
:
Depends on: 47114
Blocks: 21386 47923
  Show dependency treegraph
 
Reported: 2018-09-25 13:17 CEST by Philipp Hahn
Modified: 2018-10-08 10:18 CEST (History)
1 user (show)

See Also:
What kind of report is it?: Bug Report
What type of bug is this?: 5: Major Usability: Impairs usability in key scenarios
Who will be affected by this bug?: 2: Will only affect a few installed domains
How will those affected feel about the bug?: 4: A User would return the product
User Pain: 0.229
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional):
Max CVSS v3 score:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Philipp Hahn univentionstaff 2018-09-25 13:17:38 CEST
25.09.18 12:43:13.374  MODULE      ( ERROR   ) : Traceback (most recent call last):
  File "/usr/sbin/univention-management-console-module", line 121, in <module>
    notifier.loop()
  File "/usr/lib/pymodules/python2.7/notifier/nf_generic.py", line 287, in loop
    step()
  File "/usr/lib/pymodules/python2.7/notifier/nf_generic.py", line 279, in step
    __min_timer = dispatch.dispatcher_run()
  File "/usr/lib/pymodules/python2.7/notifier/dispatch.py", line 72, in dispatcher_run
    if not disp():
  File "/usr/lib/pymodules/python2.7/notifier/threads.py", line 154, in _simple_threads_dispatcher
    task.announce()
  File "/usr/lib/pymodules/python2.7/notifier/threads.py", line 135, in announce
    self._callback( self, self._result )
  File "/usr/lib/pymodules/python2.7/notifier/__init__.py", line 104, in __call__
    return self._function( *tmp, **self._kwargs )
  File "/usr/lib/pymodules/python2.7/univention/management/console/modules/uvmm/uvmmd.py", line 160, in _finished
    self._user_callback(thread, result)
  File "/usr/lib/pymodules/python2.7/notifier/__init__.py", line 104, in __call__
    return self._function( *tmp, **self._kwargs )
  File "/usr/lib/pymodules/python2.7/univention/management/console/modules/uvmm/__init__.py", line 96, in _process_uvmm_response
    self.thread_finished_callback(thread, result, request)
  File "/usr/lib/pymodules/python2.7/univention/management/console/base.py", line 292, in thread_finished_callback
    self.__error_handling(request, method, thread.exc_info[0], thread.exc_info[1], thread.trace)
  File "/usr/lib/pymodules/python2.7/univention/management/console/base.py", line 357, in __error_handling
    trace = ''.join(trace + traceback.format_exception_only(*sys.exc_info()[:2]))
TypeError: unsupported operand type(s) for +: 'NoneType' and 'list'


/usr/lib/pymodules/python2.7/univention/management/console/base.py:222
-  trace = etraceback
+  trace = etraceback or []

+++ This bug was initially created as a clone of Bug #47114 +++
Comment 1 Philipp Hahn univentionstaff 2018-09-25 13:28:47 CEST
[4.3-2] 8f09ffb94c Bug #47857 UMC: Fix traceback handling
 management/univention-management-console/debian/changelog         | 6 ++++++
 .../src/univention/management/console/base.py                     | 8 ++++----
 2 files changed, 10 insertions(+), 4 deletions(-)

Package: univention-management-console
Version: 10.0.6-14A~4.3.0.201809251323
Branch: ucs_4.3-0
Scope: errata4.3-2

[4.3-2] b2f826ef4e Bug #45598: univention-management-console 10.0.6-14A~4.3.0.201809251323
 doc/errata/staging/univention-management-console.yaml | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)
Comment 2 Jürn Brodersen univentionstaff 2018-09-26 10:16:26 CEST
What I tested:
Normal tracebacks -> OK
Tracebacks in threads -> OK
UMC Error -> OK

YAML -> OK

-> Verified
Comment 3 Erik Damrose univentionstaff 2018-09-26 13:24:59 CEST
<http://errata.software-univention.de/ucs/4.3/248.html>