Bug 47871 - don't run system dependent code at import time
don't run system dependent code at import time
Status: CLOSED FIXED
Product: UCS
Classification: Unclassified
Component: Listener (univention-directory-listener)
UCS 4.3
Other Linux
: P5 normal (vote)
: UCS 4.3-2-errata
Assigned To: Daniel Tröder
Philipp Hahn
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2018-09-27 09:40 CEST by Daniel Tröder
Modified: 2018-09-27 13:05 CEST (History)
0 users

See Also:
What kind of report is it?: Bug Report
What type of bug is this?: 2: Improvement: Would be a product improvement
Who will be affected by this bug?: 2: Will only affect a few installed domains
How will those affected feel about the bug?: 1: Nuisance – not a big deal but noticeable
User Pain: 0.023
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional):
Max CVSS v3 score:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Tröder univentionstaff 2018-09-27 09:40:08 CEST
pwd.getpwnam('listener').pw_uid and grp.getgrnam('adm').gr_gid at class scope fails on non-UCS systems.
Comment 1 Daniel Tröder univentionstaff 2018-09-27 09:45:53 CEST
A little cleanup:
* log listener module deactivation
* don't run system code at import time

[4.3-2] c9ea5f3426 Bug #47871: log listener module deactivation, don't run system code at import time
[4.3-2] 1a05baeb21 Bug #47871: advisory

univention-directory-listener (12.0.0-29)
Comment 2 Philipp Hahn univentionstaff 2018-09-27 11:38:56 CEST
OK: YAML
OK: c9ea5f3426
FAIL: /usr/share/ucs-test/10_ldap/41listener_module_api_test
Comment 3 Philipp Hahn univentionstaff 2018-09-27 12:29:54 CEST
OK: /usr/share/ucs-test/10_ldap/41listener_module_api_test
Comment 4 Philipp Hahn univentionstaff 2018-09-27 12:31:16 CEST
[4.3-2] e6940527a7 Bug #47871: fix TypeError
 .../univention-directory-listener/debian/changelog      |  6 ++++++
 .../python/univention/listener/handler_logging.py       | 17 +++++------------
 .../python/univention/listener/handler_logging.pyi      |  3 ---
 3 files changed, 11 insertions(+), 15 deletions(-)

[4.3-2] 502fbd47a6 Bug #47871: advisory update
 doc/errata/staging/univention-directory-listener.yaml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

OK: /usr/share/ucs-test/10_ldap/41listener_module_api_test
OK: errata-announce -V --only univention-directory-listener.yaml
Comment 5 Erik Damrose univentionstaff 2018-09-27 13:05:47 CEST
<http://errata.software-univention.de/ucs/4.3/256.html>