Bug 48989 – 26univention-samba.inst passes value of /etc/machine.secret unquoted

Bug 48989 - 26univention-samba.inst passes value of /etc/machine.secret unquoted


Summary:	26univention-samba.inst passes value of /etc/machine.secret unquoted

Status:	CLOSED FIXED

Product:	UCS
Classification:	Unclassified
Component:	Samba
Version:	UCS 4.4
Hardware:	Other Linux

Importance:	P5 normal (vote)
Target Milestone:	UCS 4.4-0-errata
Assigned To:	Daniel Tröder
QA Contact:	Arvid Requate

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2019-03-14 10:58 CET by Arvid Requate
Modified:	2019-03-20 12:29 CET (History)
CC List:	2 users (show)

See Also:	48992
What kind of report is it?:	Bug Report
What type of bug is this?:	3: Simply Wrong: The implementation doesn't match the docu
Who will be affected by this bug?:	2: Will only affect a few installed domains
How will those affected feel about the bug?:	2: A Pain – users won’t like this once they notice it
User Pain:	0.069
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional):
Max CVSS v3 score:

Attachments
fix-quoting-26univention-samba.inst (1.26 KB, patch) 2019-03-14 10:58 CET, Arvid Requate	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Arvid Requate

2019-03-14 10:58:52 CET

Created attachment 9923 [details]
fix-quoting-26univention-samba.inst

In 26univention-samba.inst the machine.secret is not quoted when storing it in samba ("smbpasswd -w" and "net idmap secret"). See attached patch.

Comment 1 Daniel Tröder

2019-03-14 12:58:19 CET

Applied patch, replaced $(cat ..) with $(< ..) for fewer forks.

[4.4-0 876e35f2c0] Bug #48989: fix quoting
[4.4-0 75374c548b] Bug #48989: advisory

univention-samba (13.0.0-2)

Comment 2 Arvid Requate

2019-03-14 13:28:38 CET

Verified:
* Code review
* Advisory & binary package version

Comment 3 Arvid Requate

2019-03-20 12:29:28 CET

<http://errata.software-univention.de/ucs/4.4/11.html>