Bug 48995 - Adjust require.toUrl() calls for dojoConfig.cacheBust
Adjust require.toUrl() calls for dojoConfig.cacheBust
Status: CLOSED FIXED
Product: UCS
Classification: Unclassified
Component: UMC (Generic)
UCS 4.4
Other Linux
: P5 normal (vote)
: UCS 4.4-0-errata
Assigned To: Johannes Keiser
Florian Best
:
: 37309 (view as bug list)
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2019-03-14 15:14 CET by Johannes Keiser
Modified: 2019-07-25 18:59 CEST (History)
1 user (show)

See Also:
What kind of report is it?: Development Internal
What type of bug is this?: ---
Who will be affected by this bug?: ---
How will those affected feel about the bug?: ---
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional):
Max CVSS v3 score:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Johannes Keiser univentionstaff 2019-03-14 15:14:55 CET
If dojoConfig.cacheBust is specified require.toUrl() will append a query string to requested files.

Some code calls require.toUrl() only on part of the url which will break the url
e.g. 
with cacheBust="bust"
var url = require.toUrl('foo/bar/') + 'icon.png'
-> 'foo/bar/?busticon.png
Comment 1 Johannes Keiser univentionstaff 2019-03-14 16:24:42 CET
491be56fa0 Bug #48995: YAML
61773f83a7 Bug #48995: YAML
a4cc87f6d9 Bug #48995: debian changelog
1e564169ef Bug #48995: fix require.toUrl() calls for cacheBust

Successful build
Package: univention-lib
Version: 8.0.0-5A~4.4.0.201903141550

Successful build
Package: univention-management-console-module-adtakeover
Version: 6.0.1-3A~4.4.0.201903141553

Successful build
Package: univention-management-console-module-udm
Version: 9.0.11-4A~4.4.0.201903141555

Successful build
Package: univention-ad-connector
Version: 13.0.0-5A~4.4.0.201903141557

Successful build
Package: univention-virtual-machine-manager-daemon
Version: 8.0.1-6A~4.4.0.201903141600

Successful build
Package: univention-web
Version: 3.0.5-4A~4.4.0.201903141602


19558f686 Bug #48995: YAML
67a31c460 Bug #48995: YAML
4e26a9d44 Bug #48995: debian changelog
8da7bb6db Bug #48995: fix require.toUrl() calls for cacheBust

Successful build
Package: ucs-school-umc-computerroom
Version: 11.0.0-2A~4.4.0.201903141616

Successful build
Package: ucs-school-umc-exam
Version: 9.0.0-4A~4.4.0.201903141619
Comment 2 Johannes Keiser univentionstaff 2019-03-14 16:51:54 CET
1857f9e6d9 Bug #48995: YAML
1b61ef3590 Bug #48995: debian changelog
989ab9a61c Bug #48995: remove unused imports
Comment 3 Florian Best univentionstaff 2019-03-14 19:06:29 CET
> Successful build
> Package: univention-lib
> Version: 8.0.0-5A~4.4.0.201903141550
OK 
> Successful build
> Package: univention-management-console-module-adtakeover
> Version: 6.0.1-3A~4.4.0.201903141553
OK
> Successful build
> Package: univention-management-console-module-udm
> Version: 9.0.11-4A~4.4.0.201903141555
OK
> Successful build
> Package: univention-ad-connector
> Version: 13.0.0-5A~4.4.0.201903141557
OK
> Successful build
> Package: univention-virtual-machine-manager-daemon
> Version: 8.0.1-6A~4.4.0.201903141600
Code-Review: OK (have no UVMM system currently)

> Successful build
> Package: univention-web
> Version: 3.0.5-4A~4.4.0.201903141602
OK

> Successful build
> Package: ucs-school-umc-computerroom
> Version: 11.0.0-2A~4.4.0.201903141616
OK
 
> Successful build
> Package: ucs-school-umc-exam
> Version: 9.0.0-4A~4.4.0.201903141619
OK
Comment 5 Florian Best univentionstaff 2019-07-25 18:59:06 CEST
*** Bug 37309 has been marked as a duplicate of this bug. ***