Bug 49163 - Migrate management/univention-self-service to dh_python2
Migrate management/univention-self-service to dh_python2
Status: CLOSED FIXED
Product: UCS
Classification: Unclassified
Component: General
UCS 4.4
All Linux
: P5 normal (vote)
: UCS 4.4-2-errata
Assigned To: Florian Best
Jürn Brodersen
:
Depends on: 49161
Blocks: 28497
  Show dependency treegraph
 
Reported: 2019-03-28 10:27 CET by Florian Best
Modified: 2019-11-13 16:04 CET (History)
1 user (show)

See Also:
What kind of report is it?: Development Internal
What type of bug is this?: ---
Who will be affected by this bug?: ---
How will those affected feel about the bug?: ---
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional):
Max CVSS v3 score:
best: Patch_Available+


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Florian Best univentionstaff 2019-03-28 10:27:16 CET
The package management/univention-self-service should be migrated to use dh_python instead of python-support.

Migration-Guide: https://hutten.knut.univention.de/mediawiki/index.php/Python_DebHelper_Migration
Comment 1 Florian Best univentionstaff 2019-10-16 13:07:08 CEST
Patch available in git:dh-python/management
Comment 2 Jürn Brodersen univentionstaff 2019-10-18 18:00:18 CEST
The following line in "debian/univention-self-service-passwordreset-umc.install" seems to be unnecessary:
"umc/python/passwordreset/sending/* usr/lib/python2.7/dist-packages/univention/management/console/modules/passwordreset/sending"

All the needed stuff to build a python3 package, like build dependencies, is there. But no python3 package is build, is this ok?

Otherwise feel free to merge
Comment 3 Florian Best univentionstaff 2019-10-21 14:02:47 CEST
(In reply to Jürn Brodersen from comment #2)
> The following line in
> "debian/univention-self-service-passwordreset-umc.install" seems to be
> unnecessary:
> "umc/python/passwordreset/sending/*
> usr/lib/python2.7/dist-packages/univention/management/console/modules/
> passwordreset/sending"
No, it's not unnecessary. dh_umc doesn't install the email_body.txt file (and I think no subfolders at all when using python-support).

> All the needed stuff to build a python3 package, like build dependencies, is
> there. But no python3 package is build, is this ok?
Yes, as discussed, I think it's okay.

> Otherwise feel free to merge
Done:
univention-self-service (4.0.3-14)
312aff92c942 | Bug #49163: migrate to dh_python

univention-self-service.yaml
312aff92c942 | Bug #49163: migrate to dh_python
Comment 4 Jürn Brodersen univentionstaff 2019-11-11 13:44:06 CET
What I tested:
jenkins -> OK
Upgrade -> OK
Password change -> OK*
Attribute change (phone) -> OK
Files moved -> OK

* I had to restart heimdal, see bug 49134. Upgrading only the self-service packages wasn't a problem -> OK

[4.4-2 a811a43fa8] Bug #49163: yaml

yaml -> OK

-> Verified
Comment 5 Erik Damrose univentionstaff 2019-11-13 16:04:35 CET
<http://errata.software-univention.de/ucs/4.4/340.html>