Bug 49168 – Migrate services/univention-ad-connector to dh_python2

Bug 49168 - Migrate services/univention-ad-connector to dh_python2


Summary:	Migrate services/univention-ad-connector to dh_python2

Status:	CLOSED FIXED

Product:	UCS
Classification:	Unclassified
Component:	General
Version:	UCS 4.4
Hardware:	All Linux

Importance:	P5 normal (vote)
Target Milestone:	UCS 4.4-3-errata
Assigned To:	Florian Best
QA Contact:	Johannes Keiser

URL:
Keywords:

Depends on:	49161 49977
Blocks:	28497
	Show dependency tree / graph

Reported:	2019-03-28 10:27 CET by Florian Best
Modified:	2020-01-13 17:14 CET (History)
CC List:	1 user (show)

See Also:	50713
What kind of report is it?:	Development Internal
What type of bug is this?:	---
Who will be affected by this bug?:	---
How will those affected feel about the bug?:	---
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional):
Max CVSS v3 score:

Flags:	best: Patch_Available+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Florian Best

2019-03-28 10:27:32 CET

The package services/univention-ad-connector should be migrated to use dh_python instead of python-support.

Migration-Guide: https://hutten.knut.univention.de/mediawiki/index.php/Python_DebHelper_Migration

Comment 1 Florian Best

2019-04-04 15:27:01 CEST

Pyshared references needs to be adjusted:

services/univention-ad-connector/debian/univention-ad-connector.univention-service:programs=/usr/share/pyshared/univention/connector/ad/main.py
services/univention-ad-connector/scripts/prepare-new-instance:    sed -i "s|/usr/share/pyshared/univention/connector/ad/main.py.*|/usr/share/pyshared/univention/connector/ad/main.py --configbase \"$CONFIGBASENAME\"|" /usr/sbin/univention-ad-"$CONFIGBASENAME"
services/univention-ad-connector/univention-ad-connector:/usr/bin/python2.7 -W ignore /usr/share/pyshared/univention/connector/ad/main.py

Comment 2 Florian Best

2019-11-12 14:48:08 CET

Patch available in git:dh-python/services

Comment 3 Florian Best

2019-12-03 16:36:57 CET

Patch applied, diff is similar to the changes for univention-s4-connector.

univention-ad-connector (13.0.0-17)
e97d3546d6fe | Bug #49168: futurize -nw --no-diffs -f lib2to3.fixes.fix_numliterals
abfd66703084 | Bug #49168: futurize -nw --no-diffs -f lib2to3.fixes.fix_long
3aa03a056256 | Bug #49168: futurize -nw --no-diffs -f lib2to3.fixes.fix_except
002bf978b9b8 | Bug #49168: futurize -nw --no-diffs -f libfuturize.fixes.fix_print_with_import modules/
b1a68465ea3f | Bug #49168: do not adjust sys.path for importing of mapping.py
e50e38321f52 | Bug #49168: pep8: fix F841: local variable is assigned to but never used
bc239eb40446 | Bug #49168: pep8 univention-ad-connector
97081e5b04be | Bug #49168: migrate to dh_python

ucs-test (9.0.3-93)
3aa26464a19c | Bug #49168: make tests pass with python-support and dh-python ad-connector

univention-ad-connector.yaml
f7921de2a399 | YAML Bug #49168

Comment 4 Johannes Keiser

2019-12-11 10:37:11 CET

OK code changes
OK debdiff / dpkg -L
OK install / upgrade
UMC module
OK yaml (f5fc81a5d5 Bug #49168: yaml)
OK jenkins
-> verified

Comment 5 Erik Damrose

2019-12-11 16:49:35 CET

<http://errata.software-univention.de/ucs/4.4/390.html>