Bug 49234 – Check if container is moveable before moving to prevent reverting

Bug 49234 - Check if container is moveable before moving to prevent reverting


Summary:	Check if container is moveable before moving to prevent reverting

Status:	CLOSED FIXED

Product:	UCS
Classification:	Unclassified
Component:	UDM (Generic)
Version:	UCS 4.4
Hardware:	Other Linux

Importance:	P5 normal (vote)
Target Milestone:	UCS 4.4-1-errata
Assigned To:	Florian Best
QA Contact:	Jürn Brodersen

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2019-04-04 18:45 CEST by Florian Best
Modified:	2019-07-31 13:58 CEST (History)
CC List:	0 users

See Also:
What kind of report is it?:	Development Internal
What type of bug is this?:	---
Who will be affected by this bug?:	---
How will those affected feel about the bug?:	---
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional):	Cleanup, Error handling
Max CVSS v3 score:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Florian Best

2019-04-04 18:45:34 CEST

When UDM moves subtrees it fails and reverts all changes if there is one object underneath of the to be moved container which can't be identified as UDM module.

This is e.g. the case for:
( WARN    ) : Could not identify LDAP object 'cn=default,cn=ppolicy,cn=univention,dc=dev,dc=local'
( WARN    ) : Could not identify LDAP object 'cn=backup,dc=dev,dc=local'
etc.

But the move starts, fails and reverts everything back.
We should check for the objects being identifyable before starting any move, so that in an error case we wouldn't need to revert anything.

Comment 1 Florian Best

2019-07-25 12:38:40 CEST

Moving containers has been delayed until all sub-objects are checked to be moveable.

univention-directory-manager-modules (14.0.13-2)
5c236833b77f | Bug #49234: check if container content is moveable

univention-directory-manager-modules.yaml
5c236833b77f | Bug #49234: check if container content is moveable

Comment 2 Jürn Brodersen

2019-07-26 11:33:51 CEST

What I tested:
Moved container with movable subobjects -> OK
Moved container with nonmovable subobjects -> Error -> OK
Jenkins -> OK

Small yaml change:
[4.4-1 9c917859fa] Bug #49234: YAML

-> Verified

Comment 3 Arvid Requate

2019-07-31 13:58:37 CEST

<http://errata.software-univention.de/ucs/4.4/205.html>