Univention Bugzilla – Bug 49930
Openldap syntax evaluation of attribute preferredDeliveryMethod broken
Last modified: 2020-04-06 13:00:08 CEST
Created attachment 10136 [details] syntax patch The Attribute preferredDeliveryMethod is an ordered set of values, which are separated by "$" Symbols. The syntax is described here: https://tools.ietf.org/html/rfc4517#page-8 Every set of values returns a syntax error, even if the syntax is correct according to the syntax description. This is due to an error in servers/slapd/schema_init.c deliveryMethodValidate
Created attachment 10137 [details] patch for DeliveryMethodValidate
Successful build Package: openldap Version: 2.4.45+dfsg-1~bpo9+1A~4.4.0.201907291444 Branch: ucs_4.4-0 Scope: errata4.4-1 Build with attached patch
Can you give some more information in this bug report?: * Did you write that patch yourself or is it part of e.g. a newer debian release, openldap, etc.? * Is there an upstream bug report?
* I created this patch * There is no upstream bug report yet, but I am planning one creating one. Further details: The syntax of preferredDeliveryMethod is a list of specified strings, separated by ' $ '. If only one value is set, e.g "physical" the syntax check works and returns valid. As soon as one specifies more e.g "telephone $ videotex" (which should work since this is an official example for the syntax) ldap_modify: Invalid syntax (21) additional info: preferredDeliveryMethod: value #0 invalid per syntax is returned. This is due to a trivial error in the function deliveryMethodValidate, which causes the syntax check to analyse the string backwards after the first space character. The attached patch fixes this.
Cool, thanks!
Verified: * Package cherry picked from errata4.3-1 to errata4.4-1 * Patches merged from 4.3-0-0-ucs/2.4.45+dfsg-1~bpo9+1-errata4.3-1 * New patch Ok: 99_preferredDeliveryMethod_syntax.patch * Patch applied during built (documented in /usr/share/doc/slapd/changelog.Debian.gz) * Functional test with example from RFC: Ok * Advisory: Ok
<http://errata.software-univention.de/ucs/4.4/208.html>
Hi Julia Thanks for that fix, when you have proposed the patch upstream, could you reference the OpenLDAP ITS issue number here? This would allow cross-referencing the bug between up- and downstream. Regards Mathieu