Bug 50056 – ucslint should detect custom_*name() in template files

Bug 50056 - ucslint should detect custom_*name() in template files


Summary:	ucslint should detect custom_*name() in template files

Status:	CLOSED FIXED

Product:	UCS
Classification:	Unclassified
Component:	ucslint
Version:	UCS 4.4
Hardware:	Other Linux

Importance:	P5 normal (vote)
Target Milestone:	UCS 4.4-4-errata
Assigned To:	Philipp Hahn
QA Contact:	Florian Best

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2019-08-26 11:59 CEST by Florian Best
Modified:	2020-06-24 12:52 CEST (History)
CC List:	2 users (show)

See Also:
What kind of report is it?:	Development Internal
What type of bug is this?:	---
Who will be affected by this bug?:	---
How will those affected feel about the bug?:	---
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional):
Max CVSS v3 score:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Florian Best

2019-08-26 11:59:59 CEST

ucslint should detect if UCR template files uses univention.lib.custom_{group,user}name().
If that's the case the Variables: section needs to mention groups/default/.* and users/default/.*.

Comment 1 Philipp Hahn

2020-06-23 10:46:42 CEST

management/univention-management-console/
E:0004-62: conffiles/usr/share/univention-management-console/meta.json: UCR template file using `custom_username()` must register for UCRV "users/default/.*"

[4.4-4] 46fd819b77 Bug #50056 ucslint: Check for custom_{user,group}name()
 doc/errata/staging/ucslint.yaml                                 | 4 +++-
 packaging/ucslint/debian/changelog                              | 1 +
 packaging/ucslint/testframework/0004-62-63.correct              | 9 +++++++++
 packaging/ucslint/testframework/0004-62-63/conffiles/etc/group1 | 5 +++++
 packaging/ucslint/testframework/0004-62-63/conffiles/etc/group2 | 5 +++++
 packaging/ucslint/testframework/0004-62-63/conffiles/etc/group3 | 5 +++++
 packaging/ucslint/testframework/0004-62-63/conffiles/etc/user1  | 5 +++++
 packaging/ucslint/testframework/0004-62-63/conffiles/etc/user2  | 5 +++++
 packaging/ucslint/testframework/0004-62-63/conffiles/etc/user3  | 5 +++++
 packaging/ucslint/testframework/0004-62-63/conffiles/etc/user4  | 5 +++++
 ...
 14 files changed, 122 insertions(+), 14 deletions(-)

Package: ucslint
Version: 8.0.0-17A~4.4.0.202006231043
Branch: ucs_4.4-0
Scope: errata4.4-4

[4.4-4] c74496ab2c Bug #49704: ucslint 8.0.0-17A~4.4.0.202006231043
 doc/errata/staging/ucslint.yaml | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

Comment 2 Florian Best

2020-06-23 18:15:28 CEST

OK: check
E:0004-62: conffiles/etc/ldap/slapd.conf.d/60univention-ldap-server_acl-master:
UCR template file using `custom_username()` must register for UCRV
"users/default/.*"

OK: YAML

Comment 3 Erik Damrose

2020-06-24 12:52:57 CEST

<http://errata.software-univention.de/ucs/4.4/630.html>