Bug 50098 - $Package.univention-service files are not build any more
$Package.univention-service files are not build any more
Status: CLOSED FIXED
Product: UCS
Classification: Unclassified
Component: UMC - System services
UCS 4.4
Other Linux
: P5 normal (vote)
: UCS 4.4-1-errata
Assigned To: Philipp Hahn
Jürn Brodersen
:
: 50170 (view as bug list)
Depends on: 42241
Blocks:
  Show dependency treegraph
 
Reported: 2019-09-03 10:19 CEST by Jürn Brodersen
Modified: 2019-09-11 15:25 CEST (History)
4 users (show)

See Also:
What kind of report is it?: Bug Report
What type of bug is this?: 5: Major Usability: Impairs usability in key scenarios
Who will be affected by this bug?: 3: Will affect average number of installed domains
How will those affected feel about the bug?: 2: A Pain – users won’t like this once they notice it
User Pain: 0.171
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional): Regression
Max CVSS v3 score:


Attachments
Check script (772 bytes, application/x-shellscript)
2019-09-05 10:39 CEST, Philipp Hahn
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Jürn Brodersen univentionstaff 2019-09-03 10:19:58 CEST
+++ This bug was initially created as a clone of Bug #42241 +++

$Package.univention-service files are not build any more.

A bug in the validation of $Package.univention-service files causes that they are not build and therefore aren't included in the package.

See for example univention-s4-connector (etc/univention/service.info is missing).

A fix is already applied but was not released. I guess because during the package build it only looked like a warning. See bug 42241 comment 20.

Test 96_samba4_sid_allocation fails because of this:
https://jenkins.knut.univention.de:8181/job/UCSschool-4.4/job/Install%20Multiserver/lastCompletedBuild/Config=s4,TestGroup=base1/testReport/90_ucsschool/96_samba4_sid_allocation/slave2032/
Comment 1 Philipp Hahn univentionstaff 2019-09-05 10:39:29 CEST
Created attachment 10171 [details]
Check script

Find broken packages:
 bzgrep -F 'Incomplete entries in services definition' /var/univention/buildsystem2/logs/ucs_4.4-0-0-errata4.4-1/*.log.bz2

Broken packages:
 univention-management-console-module-udm        /var/univention/buildsystem2/mirror/ftp/4.4/maintained/component/4.4-1-errata/all/univention-management-module-udm_9.0.12-23A~4.4.0.201908061552_all.deb        FAIL
 univention-management-console   /var/univention/buildsystem2/mirror/ftp/4.4/maintained/component/4.4-1-errata/all/univention-management-console-server_11.0.4-36A~4.4.0.201908081448_all.deb    FAIL
 univention-management-console   /var/univention/buildsystem2/mirror/ftp/4.4/maintained/component/4.4-1-errata/all/univention-management-console-web-server_11.0.4-36A~4.4.0.201908081448_all.deb        FAIL
 univention-s4-connector /var/univention/buildsystem2/mirror/ftp/4.4/maintained/component/4.4-1-errata/all/univention-s4-connector_13.0.2-42A~4.4.0.201908221334_all.deb FAIL


Before any more broken Errata are released - which just happened yesterday:

[4.4-1] 7b43a82fb6 Bug #50098: Install debian/*.univention-service files again
 base/univention-config-registry/debian/changelog | 6 ++++++
 1 file changed, 6 insertions(+)

Package: univention-config-registry
Version: 14.0.0-12A~4.4.0.201909041712
Branch: ucs_4.4-0
Scope: errata4.4-1

No source change required for the broken packages, just a re-compile with the fixed UCS package:
 b44-scope errata4.4-1 univention-management-console-module-udm univention-management-console univention-s4-connector

Package: univention-management-console-module-udm
Version: 9.0.12-32A~4.4.0.201909050925
Branch: ucs_4.4-0
Scope: errata4.4-1

Package: univention-management-console
Version: 11.0.4-36A~4.4.0.201909050927
Branch: ucs_4.4-0
Scope: errata4.4-1

Package: univention-s4-connector
Version: 13.0.2-42A~4.4.0.201909050929
Branch: ucs_4.4-0
Scope: errata4.4-1

QA:
 cd /var/univention/buildsystem2/apt/ucs_4.4-0-errata4.4-1/all
 dpkg -c univention-s4-connector_13.0.2-42A~4.4.0.201909050929_all.deb | grep -F etc/univention/service.info/services/
 dpkg -c univention-management-console-web-server_11.0.4-36A~4.4.0.201909050927_all.deb | grep -F etc/univention/service.info/services/
 dpkg -c univention-management-console-server_11.0.4-36A~4.4.0.201909050927_all.deb | grep -F etc/univention/service.info/services/
 dpkg -c univention-management-module-udm_9.0.12-32A~4.4.0.201909050925_all.deb | grep -F etc/univention/service.info/services/

FYI: The release of the 3 fixed packages is independent from the fix to UCR; strictly speaking those packages should get new bug# to release them independently from each other as they don't block each other.
Comment 2 Philipp Hahn univentionstaff 2019-09-05 10:46:50 CEST
[4.4-1] 4631bcfb79 Bug #50098: univention-service YAML
 doc/errata/staging/univention-config-registry.yaml            | 11 +++++++++++
 .../staging/univention-management-console-module-udm.yaml     |  9 ++++++---
 doc/errata/staging/univention-management-console.yaml         | 10 ++++++----
 doc/errata/staging/univention-s4-connector.yaml               | 11 +++++++++++
 4 files changed, 34 insertions(+), 7 deletions(-)

[4.4-1] 60101678ef Bug #50098 devdoc: Fix documentation
 doc/developer-reference/ucr/ucr.xml | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

<http://jenkins.knut.univention.de:8080/job/UCS-4.4/job/UCS-4.4-1/view/Documentation/job/HandbookDeveloper/lastSuccessfulBuild/artifact/webroot/developer-reference-4.4.html#ucr:conf>
<http://jenkins.knut.univention.de:8080/job/UCS-4.4/job/UCS-4.4-1/view/Documentation/job/HandbookDeveloper/lastSuccessfulBuild/artifact/webroot/developer-reference-4.4.html#ucr:services>
Comment 3 Jürn Brodersen univentionstaff 2019-09-05 15:14:22 CEST
What I tested:
Packages from comment 1 contain service.info/... files again -> OK

rm /etc/univention/service.info/services/univention-management-console-server.cfg;
 apt -o Dpkg::Options::="--force-confdef" -o Dpkg::Options::="--force-confold" -o DPkg::options::="--force-confmiss" install --reinstall univention-management-console-server -> univention-management-console-server.cfg is recreated -> OK

Docs -> OK
YAML -> OK

I added a small test:
[4.4-1 97c0761a38] Bug #50098: Add 03_ucr/68check_univention-service.py
Comment 4 Jürn Brodersen univentionstaff 2019-09-05 15:22:24 CEST
Nothing to do for ucsschool

bzgrep -F 'Incomplete entries in services definition' /var/univention/buildsystem2/logs/ucs_4.4-0-0-ucs-school-4.4/*.log.bz2 -> finds nothing -> OK
Comment 5 Philipp Hahn univentionstaff 2019-09-10 14:05:44 CEST
*** Bug 50170 has been marked as a duplicate of this bug. ***