Bug 50394 - umc diagnostic: wrong test in 31_file_permissions
umc diagnostic: wrong test in 31_file_permissions
Status: CLOSED FIXED
Product: UCS
Classification: Unclassified
Component: General
UCS 4.4
Other Linux
: P5 normal (vote)
: UCS 4.4-2-errata
Assigned To: Felix Botner
Arvid Requate
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2019-10-21 11:24 CEST by Felix Botner
Modified: 2019-11-13 16:04 CET (History)
2 users (show)

See Also:
What kind of report is it?: Development Internal
What type of bug is this?: ---
Who will be affected by this bug?: ---
How will those affected feel about the bug?: ---
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional):
Max CVSS v3 score:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Felix Botner univentionstaff 2019-10-21 11:24:34 CEST
In our jenkins test we sometimes get 

###################### Start 31_file_permissions #######################
[2019-10-20 23:54:51.879108] ## Check failed: 31_file_permissions - Überprüfe Datei Berechtigungen ##
[2019-10-20 23:54:51.879155] Datei '/var/lock/sysvol-sync-dir' hat den Besitzer 'master093$:DC Slave Hosts', während 'root:DC Slave Hosts' erwartet war.
[2019-10-20 23:54:51.879184] ####################### End 31_file_permissions ########################
[2019-10-20 23:54:51.879256] 

but i guess this is not correct. If the master syncs to the backup this 'master093$:DC Slave Hosts' is a totally valid ownership.
Comment 1 Felix Botner univentionstaff 2019-10-21 11:38:05 CEST
Just removed the '/var/lock/sysvol-sync-dir' test.
Comment 2 Florian Best univentionstaff 2019-10-21 11:45:32 CEST
The correct fix would be Bug #49036.
If you remove the line we don't win anything. Please re-add it with a comment that it's broken due to Bug #49036.
Comment 3 Felix Botner univentionstaff 2019-10-21 12:36:51 CEST
(In reply to Florian Best from comment #2)
> The correct fix would be Bug #49036.
> If you remove the line we don't win anything. Please re-add it with a
> comment that it's broken due to Bug #49036.

I do not see the connection to Bug #49036, and i will not re-add the line, because this test is wrong! /var/lock/sysvol-sync-dir can have another owner than "root", so the test for root as owner is invalid.

This is not about the ssl directories!
Comment 4 Arvid Requate univentionstaff 2019-10-21 19:32:12 CEST
Verified:
* Comment 3
* Code review
* Advisory
Comment 5 Arvid Requate univentionstaff 2019-10-21 19:37:21 CEST
Ah, it's Florian's QA, sorry.
Comment 6 Florian Best univentionstaff 2019-10-24 10:02:56 CEST
(In reply to Arvid Requate from comment #5)
> Ah, it's Florian's QA, sorry.
But you already did the QA :-)
Comment 7 Erik Damrose univentionstaff 2019-11-13 16:04:38 CET
<http://errata.software-univention.de/ucs/4.4/336.html>