Bug 50475 - Migrate univention-python-heimdal to Python 3
Migrate univention-python-heimdal to Python 3
Status: CLOSED FIXED
Product: UCS
Classification: Unclassified
Component: Kerberos
UCS 4.4
Other Linux
: P5 normal (vote)
: UCS 4.4-3-errata
Assigned To: Philipp Hahn
Arvid Requate
:
Depends on:
Blocks: 49060 51360
  Show dependency treegraph
 
Reported: 2019-11-08 15:37 CET by Florian Best
Modified: 2020-05-26 15:50 CEST (History)
2 users (show)

See Also:
What kind of report is it?: Development Internal
What type of bug is this?: ---
Who will be affected by this bug?: ---
How will those affected feel about the bug?: ---
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional):
Max CVSS v3 score:
hahn: Patch_Available+


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Florian Best univentionstaff 2019-11-08 15:37:41 CET
base/univention-python-heimdal should be migrated to python 3.

Please also consider Bug #49383, Bug #38736, Bug #23159.

Please also consider to rename the packages:
We don't expose "univention.heimdal" but "heimdal", so maybe the package name can be python{3,}-heimdal instead of python-univention-heimdal.
Comment 1 Philipp Hahn univentionstaff 2019-12-08 23:51:45 CET
git:phahn/49139_dhpy2-heimdal
Comment 2 Philipp Hahn univentionstaff 2019-12-18 17:53:32 CET
[4.4-3] bb118a0e46 Bug #50475,#49383,#38736 Heimdal: Merge branch 'phahn/49139_dhpy2-heimdal' into 4.4-3

Package: univention-python-heimdal
Version: 9.0.0-3A~4.4.0.201912181749
Branch: ucs_4.4-0
Scope: errata4.4-3

[4.4-3] 6740211353 Bug #50475: univention-python-heimdal 9.0.0-3A~4.4.0.201912181749
 doc/errata/staging/univention-python-heimdal.yaml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Comment 3 Arvid Requate univentionstaff 2020-03-11 11:45:42 CET
Verified:
* Define and build python3-* Packages
* Switch to PEP-353 by defining PY_SSIZE_T_CLEAN before each include of Python.h
* Use io.open in setup.py for Python2+3 compatibility
* asn1_encode_key + keyblock_keyvalue + keytab_list now return PyBytes instead of PyString iff PY3
* creds_parse + enctype_string + principal_realm + salt_saltvalue now return PyUnicode instead of PyString iff PY3
* enctype_string and principal_name are now used for str() instead of repr()
* keyblock_raw_new now only accepts bytes object iff PY3 (used e.g. as "heimdal.keyblock_raw" in ADC and S4C password.py)
* Switch from PyInt_FromLong to PyLong_FromLong iff PY3
* Switch from PyInt_AsLong to PyLong_AsLong iff PY3
* Rename krb5_error_code variable 'ret' to 'err'
* Add proper C header file include guards, missing in most .h files
* More robust exception handling in context_get_permitted_enctypes
* Convert from Py_FindMethod to .tp_methods
* Clean up PyTypeObject structure initialization by making use of designators
* unittest code looks good and works
Comment 4 Philipp Hahn univentionstaff 2020-03-11 12:08:21 CET
[4.4-3] ab011cb15f Bug #50475: Fix Python 3 support
 base/univention-python-heimdal/debian/changelog | 6 ++++++
 base/univention-python-heimdal/module.c         | 6 +++++-
 2 files changed, 11 insertions(+), 1 deletion(-)

Package: univention-python-heimdal
Version: 9.0.0-4A~4.4.0.202003111158
Branch: ucs_4.4-0
Scope: errata4.4-3

[4.4-3] 3303bac305 Bug #50475: univention-python-heimdal 9.0.0-4A~4.4.0.202003111158
 doc/errata/staging/univention-python-heimdal.yaml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Comment 5 Erik Damrose univentionstaff 2020-03-11 13:09:41 CET
OK: Fix cornercase
OK: yaml
-Verified
Comment 6 Erik Damrose univentionstaff 2020-03-11 14:41:48 CET
<http://errata.software-univention.de/ucs/4.4/477.html>