Bug 50521 - univention-l18n.input_files is a regular expression
univention-l18n.input_files is a regular expression
Status: CLOSED FIXED
Product: UCS
Classification: Unclassified
Component: General
UCS 4.4
Other Linux
: P5 normal (vote)
: UCS 4.4-2-errata
Assigned To: Philipp Hahn
Florian Best
:
Depends on: 50341
Blocks:
  Show dependency treegraph
 
Reported: 2019-11-20 13:55 CET by Philipp Hahn
Modified: 2019-11-27 14:20 CET (History)
4 users (show)

See Also:
What kind of report is it?: Development Internal
What type of bug is this?: ---
Who will be affected by this bug?: ---
How will those affected feel about the bug?: ---
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional):
Max CVSS v3 score:
hahn: Patch_Available+


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Philipp Hahn univentionstaff 2019-11-20 13:55:35 CET
The debina/$pkg.univention-l10nj file format is not documented and has led to the assumption, that 'input_files' is a list of "file names" or "globbing expressions", but it is a "regular expression".

At least two packages are therefor missing or outdated translations:
- management/univention-appcenter
- saml/univention-saml
- test/ucs-test

Add documentation
Fix broken $pkg.univention-l10n files
Optional: write JSON schema
Optional: write ucslint test
Comment 1 Philipp Hahn univentionstaff 2019-11-20 14:23:15 CET
Package: univention-ucs-translation-template
Version: 6.0.0-13A~4.4.0.201911201420
Branch: ucs_4.4-0
Scope: errata4.4-2

[4.4-2] d50c50a0ea Bug #50521: univention-ucs-translation-template 6.0.0-13A~4.4.0.201911201420
 doc/errata/staging/univention-ucs-translation-template.yaml | 10 ++++++++++
 1 file changed, 10 insertions(+)

[4.4-2] 18ca2900ac Bug #50521: Merge branch 'phahn/50521-l10n' into 4.4-2
Comment 2 Florian Best univentionstaff 2019-11-20 14:50:30 CET
OK: docs
OK: changed univention-l10n files
OK~: YAML
Comment 3 Philipp Hahn univentionstaff 2019-11-20 16:25:41 CET
(In reply to Philipp Hahn from comment #0)
> Optional: write JSON schema

[4.4-2] d768e59931 Bug #50521 l10n: Add JSON schema
 .../univention-l10n.schema.json                    | 92 ++++++++++++++++++++++
 1 file changed, 92 insertions(+)
Comment 4 Felix Botner univentionstaff 2019-11-21 12:22:35 CET
Can't build ucs-test currently, error is

  E:0008-3: univention/testing/selenium/de.po:144: contains "fuzzy"

but haven't changed anything related to univention/testing

Could this be a side-effect of this change?
Comment 5 Florian Best univentionstaff 2019-11-21 12:40:29 CET
(In reply to Felix Botner from comment #4)
> Can't build ucs-test currently, error is
> 
>   E:0008-3: univention/testing/selenium/de.po:144: contains "fuzzy"
> 
> but haven't changed anything related to univention/testing
> 
> Could this be a side-effect of this change?

Executing "univention-l10n-build de" and commiting this fixed it.

ucs-test (9.0.3-107)
901f615b3170 | Bug #50521: add empty translation files
Comment 6 Florian Best univentionstaff 2019-11-21 13:01:10 CET
OK: JSON-Schema
OK: ucs-test
Comment 7 Arvid Requate univentionstaff 2019-11-27 14:20:11 CET
<http://errata.software-univention.de/ucs/4.4/382.html>